Prev: [034/117] ocfs2_dlmfs: Fix math error when reading LVB.
Next: [025/117] USB: dont read past config->interface[] if usb_control_msg() fails in usb_reset_configuration()
From: Greg KH on 10 May 2010 19:50
2.6.33-stable review patch. If anyone has any objections, please let us know.

------------------

From: Alan Stern <stern(a)rowland.harvard.edu>

commit 62f9cfa3ece58268b3e92ca59c23b175f86205aa upstream.

This patch (as1372) fixes a bug in the routine that chooses the
default configuration to install when a new USB device is detected.
The algorithm is supposed to look for a config whose first interface
is for a non-vendor-specific class. But the way it's currently
written, it will also accept a config with no interfaces at all, which
is not very useful. (Believe it or not, such things do exist.)

Signed-off-by: Alan Stern <stern(a)rowland.harvard.edu>
Tested-by: Andrew Victor <avictor.za(a)gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
drivers/usb/core/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/core/generic.c
+++ b/drivers/usb/core/generic.c
@@ -120,7 +120,7 @@ int usb_choose_configuration(struct usb_
* than a vendor-specific driver. */
else if (udev->descriptor.bDeviceClass !=
USB_CLASS_VENDOR_SPEC &&
- (!desc || desc->bInterfaceClass !=
+ (desc && desc->bInterfaceClass !=
USB_CLASS_VENDOR_SPEC)) {
best = c;
break;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [034/117] ocfs2_dlmfs: Fix math error when reading LVB.
Next: [025/117] USB: dont read past config->interface[] if usb_control_msg() fails in usb_reset_configuration()