[073/139] x86/amd-iommu: Use helper function to destroy domain
in [Kernel]
|
Prev: [095/139] pci: Update pci_set_vga_state() to call arch functions
Next: [091/139] quota: Fix possible dq_flags corruption
From: Greg KH on 22 Apr 2010 16:20 2.6.33-stable review patch. If anyone has any objections, please let us know. ------------------ From: Joerg Roedel <joerg.roedel(a)amd.com> commit 8b408fe4f853dcfa18d133aa4cf1d7546b4c3870 upstream. In the amd_iommu_domain_destroy the protection_domain_free function is partly reimplemented. The 'partly' is the bug here because the domain is not deleted from the domain list. This results in use-after-free errors and data-corruption. Fix it by just using protection_domain_free instead. Signed-off-by: Joerg Roedel <joerg.roedel(a)amd.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de> --- arch/x86/kernel/amd_iommu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/arch/x86/kernel/amd_iommu.c +++ b/arch/x86/kernel/amd_iommu.c @@ -2379,9 +2379,7 @@ static void amd_iommu_domain_destroy(str free_pagetable(domain); - domain_id_free(domain->id); - - kfree(domain); + protection_domain_free(domain); dom->priv = NULL; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |