Prev: [17/54] drivers/video/w100fb.c: ignore void return value / fix build failure
Next: [06/67] x86/PCI: use host bridge _CRS info on ASRock ALiveSATA2-GLAN
From: Greg KH on 11 Aug 2010 20:30
2.6.34-stable review patch. If anyone has any objections, please let us know.

------------------

From: Peter Huewe <peterhuewe(a)gmx.de>

commit 060132ae42cce3f9d2fd34d9a17b98362b44b9f9 upstream.

This patch prevents the code from calling parport_release and
parport_unregister_device twice with the same arguments - and thus fixes an oops.

Rationale:
After the first call the parport is already released and the
handle isn't valid anymore and calling parport_release and
parport_unregister_device twice isn't a good idea.

Signed-off-by: Peter Huewe <peterhuewe(a)gmx.de>
Acked-by: Willy Tarreau <w(a)1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
drivers/staging/panel/panel.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -2180,6 +2180,7 @@ int panel_init(void)
if (pprt) {
parport_release(pprt);
parport_unregister_device(pprt);
+ pprt = NULL;
}
parport_unregister_driver(&panel_driver);
printk(KERN_ERR "Panel driver version " PANEL_VERSION
@@ -2229,6 +2230,7 @@ static void __exit panel_cleanup_module(
/* TODO: free all input signals */
parport_release(pprt);
parport_unregister_device(pprt);
+ pprt = NULL;
}
parport_unregister_driver(&panel_driver);
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [17/54] drivers/video/w100fb.c: ignore void return value / fix build failure
Next: [06/67] x86/PCI: use host bridge _CRS info on ASRock ALiveSATA2-GLAN