[1/23] x86: percpu: Avoid warnings of unused variables in per cpu
in [Kernel]
|
Prev: [PATCH] [2/23] IRQ: Move alloc_desk_mask variables inside ifdef
Next: [PATCH] [9/23] PRINTK: Use stable variable to dump kmsg buffer
From: Tejun Heo on 10 Jun 2010 07:20 On 06/10/2010 01:10 PM, Andi Kleen wrote: > Avoid hundreds of warnings with a gcc 4.6 -Wall build > > Cc: tj(a)kernel.org > Cc: x86(a)kernel.org > > Signed-off-by: Andi Kleen <ak(a)linux.intel.com> Acked-by: Tejun Heo <tj(a)kernel.org> Can x86 or -mm please take this patch? There isn't any pending percpu patch currently and it seems a bit silly to start a branch for this one. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ingo Molnar on 10 Jun 2010 08:20 * Tejun Heo <tj(a)kernel.org> wrote: > On 06/10/2010 01:10 PM, Andi Kleen wrote: > > Avoid hundreds of warnings with a gcc 4.6 -Wall build > > > > Cc: tj(a)kernel.org > > Cc: x86(a)kernel.org > > > > Signed-off-by: Andi Kleen <ak(a)linux.intel.com> > > Acked-by: Tejun Heo <tj(a)kernel.org> > > Can x86 or -mm please take this patch? There isn't any pending percpu > patch currently and it seems a bit silly to start a branch for this > one. Sure, queued it up. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Justin P. Mattock on 10 Jun 2010 13:50 On 06/10/2010 05:09 AM, Ingo Molnar wrote: > > * Tejun Heo<tj(a)kernel.org> wrote: > >> On 06/10/2010 01:10 PM, Andi Kleen wrote: >>> Avoid hundreds of warnings with a gcc 4.6 -Wall build >>> >>> Cc: tj(a)kernel.org >>> Cc: x86(a)kernel.org >>> >>> Signed-off-by: Andi Kleen<ak(a)linux.intel.com> >> >> Acked-by: Tejun Heo<tj(a)kernel.org> >> >> Can x86 or -mm please take this patch? There isn't any pending percpu >> patch currently and it seems a bit silly to start a branch for this >> one. > > Sure, queued it up. > > Thanks, > > Ingo > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > Thanks for this.. I applied it over here.. and now don't have all of that spam from percpu while compiling the kernel.. only one I see now is something about warning: variable 'gfp' set but not used if there's another I can test it if you would like. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Justin P. Mattock on 10 Jun 2010 14:30 On 06/10/2010 11:10 AM, Andi Kleen wrote: >> Thanks for this.. I applied it over >> here.. and now don't have all of >> that spam from percpu while compiling >> the kernel.. > > Which gcc version are you using? gcc version 4.6.0 20100416 >> >> only one I see now is something about >> warning: variable 'gfp' set but not used > > That's fixed in 'IRQ: Move alloc_desk_mask variables inside ifdef' > > The whole series fixes a lot more warnings, however > there are still quite some left (in my config) > > -Andi let me go and add all of these patches, to see if I see any more warnings.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Justin P. Mattock on 10 Jun 2010 16:20
On 06/10/2010 11:10 AM, Andi Kleen wrote: >> Thanks for this.. I applied it over >> here.. and now don't have all of >> that spam from percpu while compiling >> the kernel.. > > Which gcc version are you using? >> >> only one I see now is something about >> warning: variable 'gfp' set but not used > > That's fixed in 'IRQ: Move alloc_desk_mask variables inside ifdef' > > The whole series fixes a lot more warnings, however > there are still quite some left (in my config) > > -Andi o.k. I applied your patches, except patch #10 x86: percpu: Avoid warnings of unused variables will try later on and see. as for the warnings, I can send a seperate post for all to see, still quit a bit but lots nicer after your patch(s) Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |