Prev: lockdep: Fix redundant_hardirqs_on incremented with irqs enabled
Next: [PATCH] Psychovisually-optimized HZ setting (2.6.33.3)
From: Xianghua Xiao on 30 Apr 2010 13:00 On Thu, Apr 29, 2010 at 10:15 AM, Phil Carmody <ext-phil.2.carmody(a)nokia.com> wrote: > On 28/04/10 19:54 +0200, ext Xianghua Xiao wrote: >> On Wed, Apr 28, 2010 at 11:34 AM, Thomas Gleixner <tglx(a)linutronix.de> wrote: > ... >> Thomas, >> I patched it and re-run it however did not find any condition from >> your patch had a hit. >> In your patch I changed : >> >> if (!file->f_path) { >> to >> if(!(&(file->f_path))){ >> Otherwise it won't compile as f_path is a not a pointer. > > That check is completely bogus. The address of _anything_ (whose address > can be taken) is _always_ non-null. > > Phil > Thomas, I confirm that 2.6.33.3-rt15 worked fine, reboot/umount will not oops. Thanks, Xianghua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Thomas Gleixner on 30 Apr 2010 13:20 On Thu, 29 Apr 2010, Xianghua Xiao wrote: > I confirm that 2.6.33.3-rt15 worked fine, reboot/umount will not oops. Just pushed out 2.6.33.3-rt17 which has the problem fixed. Can you please verify that it works for you as well ? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Xianghua Xiao on 30 Apr 2010 13:50 On Fri, Apr 30, 2010 at 5:02 AM, Thomas Gleixner <tglx(a)linutronix.de> wrote: > On Thu, 29 Apr 2010, Xianghua Xiao wrote: >> I confirm that 2.6.33.3-rt15 worked fine, reboot/umount will not oops. > > Just pushed out 2.6.33.3-rt17 which has the problem fixed. Can you > please verify that it works for you as well ? > > Thanks, > > tglx > Yes it works fine now. Thanks a lot for the efforts! Xianghua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Thomas Gleixner on 30 Apr 2010 15:00
On Wed, 28 Apr 2010, Xianghua Xiao wrote: > here it is, just in case I also attached the source file related: > addr2line -e vmlinux c009ded8 c009de88 > /home/xxiao/xxiao/linux-2.6.33.3/fs/file_table.c:436 The code line in all traces is if (inode->i_nlink == 0) and interestingly enough the inode pointer is not NULL, in the various traces there are random values: 0x00000008, 0x00000010, 0x2e657468, 0x31c5547a Can you please verify whether 2.6.33.3-rt15 works ? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |