2.6.33.5-rt23
in [Kernel]
|
From: Will Schmidt on 9 Jun 2010 17:40 On Wed, 2010-06-09 at 18:44 +0200, Thomas Gleixner wrote: > We are pleased to announce the next update to our new preempt-rt > series. > <snip> > Changes from 2.6.33.4-rt21 to 2.6.33.5-rt22: > > ef4afcc: Merge stable/linux-2.6.33.y into rt/2.6.33 > > Changes from 2.6.33.5-rt22 to 2.6.33.5-rt23: > > ab774e8: drivers/hwmon/coretemp.c: get TjMax value from MSR > e8bfcca: drivers/hwmon/coretemp.c: detect the thermal sensors by CPUID > a06a867: dcache: Prevent d_genocide() from decrementing d_count more than once > bdeadaf: nfs: Avoid igrab deadlock. > 6976846: dcache: Fix select_parent dentry traversal locking > 1f0f6ec: powerpc: chrp/time.c fix preprocessor conditional I'm still on 2.6.33.5-rt22 on powerpc, and have run into a couple "sleeping function called from invalid context..." BUGs. The first was during system boot, second during a 'make'. relevant code paths don't seem to have changed between -rt22 and -rt23, so I think still valid.. :-) This is on a POWER7 system, which may have opened up some timing windows, wrt previous runs on POWER6 systems. BUG: sleeping function called from invalid context at kernel/rtmutex.c:684 pcnt: 1 0 in_atomic(): 1, irqs_disabled(): 1, pid: 3209, name: ip Call Trace: [c000000078cf28e0] [c000000000015550] .show_stack+0xd8/0x218 (unreliable) [c000000078cf29c0] [c0000000006a99c8] .dump_stack+0x28/0x3c [c000000078cf2a40] [c00000000006cea8] .__might_sleep+0x134/0x15c [c000000078cf2ae0] [c0000000006a2f78] .rt_spin_lock+0x4c/0x9c [c000000078cf2b70] [c0000000001799e8] ._slab_irq_disable+0x70/0xd8 [c000000078cf2c20] [c00000000017d1b4] .kmem_cache_alloc_node_notrace +0x78/0x234 [c000000078cf2cf0] [c000000000131a04] .irq_to_desc_alloc_node+0xdc/0x2b8 [c000000078cf2db0] [c00000000000f238] .irq_setup_virq+0x44/0xe4 [c000000078cf2e50] [c00000000000f3f8] .irq_create_mapping+0x120/0x188 [c000000078cf2ef0] [c00000000002edfc] .ibmebus_request_irq+0x50/0xac [c000000078cf2fa0] [c0000000004f3bd0] .ehea_up+0x314/0x69c [c000000078cf30b0] [c0000000004f3fc8] .ehea_open+0x70/0x128 [c000000078cf3150] [c0000000005e504c] .dev_open+0x120/0x198 [c000000078cf31f0] [c0000000005e3ee8] .dev_change_flags+0x11c/0x21c [c000000078cf32a0] [c0000000005f10ec] .do_setlink+0x2e0/0x400 [c000000078cf3380] [c0000000005f23a0] .rtnl_newlink+0x380/0x5b8 [c000000078cf3580] [c0000000005f1fd4] .rtnetlink_rcv_msg+0x258/0x2a4 [c000000078cf3630] [c000000000604094] .netlink_rcv_skb+0x84/0x120 [c000000078cf36d0] [c0000000005f1d58] .rtnetlink_rcv+0x38/0x5c [c000000078cf3760] [c000000000603ba0] .netlink_unicast+0x31c/0x3fc [c000000078cf3840] [c000000000604838] .netlink_sendmsg+0x2c8/0x30c [c000000078cf3930] [c0000000005c8bdc] .sock_sendmsg+0xbc/0xfc [c000000078cf3b10] [c0000000005c92fc] .SyS_sendmsg+0x20c/0x2a4 [c000000078cf3d50] [c0000000005c7f6c] .SyS_socketcall+0x238/0x2b0 [c000000078cf3e30] [c00000000000852c] syscall_exit+0x0/0x40 BUG: sleeping function called from invalid context at kernel/rtmutex.c:684 pcnt: 0 0 in_atomic(): 0, irqs_disabled(): 1, pid: 4760, name: make Call Trace: [c0000000792978b0] [c000000000015550] .show_stack+0xd8/0x218 (unreliable) [c000000079297990] [c0000000006a99c8] .dump_stack+0x28/0x3c [c000000079297a10] [c00000000006cea8] .__might_sleep+0x134/0x15c [c000000079297ab0] [c0000000006a2f78] .rt_spin_lock+0x4c/0x9c [c000000079297b40] [c0000000000a1ff0] .get_signal_to_deliver+0xcc/0x4ec [c000000079297c50] [c000000000018604] .do_signal_pending.clone.0+0x6c/0x2e0 [c000000079297d90] [c0000000000188b0] .do_signal+0x38/0x74 [c000000079297e30] [c000000000008b40] user_work+0x24/0x28 > > Bulk of changes comes from stable tree. The -rt related changes are > mostly fixes for the vfs fallout the rest are fixlets all over the > place and hardware enablement. > > Download locations: > > http://www.kernel.org/pub/linux/kernel/projects/rt/ > > Git release branch: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git rt/2.6.33 > > Gitweb: > http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=shortlog;h=rt/2.6.33 > > Information on the RT patch can be found at: > > http://rt.wiki.kernel.org/index.php/Main_Page > > To build the 2.6.33.5-rt23 tree, the following patches should be > applied: > > http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.33.5.tar.bz2 > http://www.kernel.org/pub/linux/kernel/projects/rt/patch-2.6.33.5-rt23.bz2 > > Enjoy ! > > tglx > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Thomas Gleixner on 10 Jun 2010 02:10 On Wed, 9 Jun 2010, Will Schmidt wrote: > On Wed, 2010-06-09 at 18:44 +0200, Thomas Gleixner wrote: > I'm still on 2.6.33.5-rt22 on powerpc, and have run into a couple > "sleeping function called from invalid context..." BUGs. The first was > during system boot, second during a 'make'. > > relevant code paths don't seem to have changed between -rt22 and -rt23, > so I think still valid.. :-) > > This is on a POWER7 system, which may have opened up some timing > windows, wrt previous runs on POWER6 systems. > > > BUG: sleeping function called from invalid context at > kernel/rtmutex.c:684 > [c000000078cf2cf0] [c000000000131a04] .irq_to_desc_alloc_node+0xdc/0x2b8 Grr. I thought I had the SPARSE_IRQ stuff disabled on -rt, but seems it came back somehow. Can you disable that, or does you machine depend on it ? > BUG: sleeping function called from invalid context at kernel/rtmutex.c:684 > pcnt: 0 0 in_atomic(): 0, irqs_disabled(): 1, pid: 4760, name: make > Call Trace: > [c0000000792978b0] [c000000000015550] .show_stack+0xd8/0x218 (unreliable) > [c000000079297990] [c0000000006a99c8] .dump_stack+0x28/0x3c > [c000000079297a10] [c00000000006cea8] .__might_sleep+0x134/0x15c > [c000000079297ab0] [c0000000006a2f78] .rt_spin_lock+0x4c/0x9c > [c000000079297b40] [c0000000000a1ff0] .get_signal_to_deliver+0xcc/0x4ec > [c000000079297c50] [c000000000018604] .do_signal_pending.clone.0+0x6c/0x2e0 > [c000000079297d90] [c0000000000188b0] .do_signal+0x38/0x74 > [c000000079297e30] [c000000000008b40] user_work+0x24/0x28 Does the patch below fix it ? Thanks, tglx ----- diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c index 00b5078..fa580f9 100644 --- a/arch/powerpc/kernel/signal.c +++ b/arch/powerpc/kernel/signal.c @@ -120,6 +120,14 @@ static int do_signal_pending(sigset_t *oldset, struct pt_regs *regs) int ret; int is32 = is_32bit_task(); +#ifdef CONFIG_PREEMPT_RT + /* + * Fully-preemptible kernel does not need interrupts disabled: + */ + local_irq_enable(); + preempt_check_resched(); +#endif + if (current_thread_info()->local_flags & _TLF_RESTORE_SIGMASK) oldset = ¤t->saved_sigmask; else if (!oldset) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Will Schmidt on 10 Jun 2010 12:00 On Thu, 2010-06-10 at 08:07 +0200, Thomas Gleixner wrote: > On Wed, 9 Jun 2010, Will Schmidt wrote: > > > On Wed, 2010-06-09 at 18:44 +0200, Thomas Gleixner wrote: > > I'm still on 2.6.33.5-rt22 on powerpc, and have run into a couple > > "sleeping function called from invalid context..." BUGs. The first was > > during system boot, second during a 'make'. > > > > relevant code paths don't seem to have changed between -rt22 and -rt23, > > so I think still valid.. :-) > > > > This is on a POWER7 system, which may have opened up some timing > > windows, wrt previous runs on POWER6 systems. > > > > > > BUG: sleeping function called from invalid context at > > kernel/rtmutex.c:684 > > > [c000000078cf2cf0] [c000000000131a04] .irq_to_desc_alloc_node+0xdc/0x2b8 > > Grr. I thought I had the SPARSE_IRQ stuff disabled on -rt, but seems > it came back somehow. Can you disable that, or does you machine depend > on it ? I'm not sure whether it is required by the architecture. I do see that SPARSE_IRQ is disabled in arch/x86/Kconfig with a !PREEMPT_RT, but I don't see an equivalent 'disable' in arch/powerpc/Kconfig. > > BUG: sleeping function called from invalid context at kernel/rtmutex.c:684 > > pcnt: 0 0 in_atomic(): 0, irqs_disabled(): 1, pid: 4760, name: make > > Call Trace: > > [c0000000792978b0] [c000000000015550] .show_stack+0xd8/0x218 (unreliable) > > [c000000079297990] [c0000000006a99c8] .dump_stack+0x28/0x3c > > [c000000079297a10] [c00000000006cea8] .__might_sleep+0x134/0x15c > > [c000000079297ab0] [c0000000006a2f78] .rt_spin_lock+0x4c/0x9c > > [c000000079297b40] [c0000000000a1ff0] .get_signal_to_deliver+0xcc/0x4ec > > [c000000079297c50] [c000000000018604] .do_signal_pending.clone.0+0x6c/0x2e0 > > [c000000079297d90] [c0000000000188b0] .do_signal+0x38/0x74 > > [c000000079297e30] [c000000000008b40] user_work+0x24/0x28 > > Does the patch below fix it ? Probably.. :-) I'm running with the patch now, and no repeats of that BUG yet. Thanks, -Will > > Thanks, > > tglx > ----- > diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c > index 00b5078..fa580f9 100644 > --- a/arch/powerpc/kernel/signal.c > +++ b/arch/powerpc/kernel/signal.c > @@ -120,6 +120,14 @@ static int do_signal_pending(sigset_t *oldset, struct pt_regs *regs) > int ret; > int is32 = is_32bit_task(); > > +#ifdef CONFIG_PREEMPT_RT > + /* > + * Fully-preemptible kernel does not need interrupts disabled: > + */ > + local_irq_enable(); > + preempt_check_resched(); > +#endif > + > if (current_thread_info()->local_flags & _TLF_RESTORE_SIGMASK) > oldset = ¤t->saved_sigmask; > else if (!oldset) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Darcy L. Watkins on 10 Jun 2010 12:30 On Thu, 2010-06-10 at 08:56 -0700, Will Schmidt wrote: > On Thu, 2010-06-10 at 08:07 +0200, Thomas Gleixner wrote: > > On Wed, 9 Jun 2010, Will Schmidt wrote: > > > > > On Wed, 2010-06-09 at 18:44 +0200, Thomas Gleixner wrote: > > > I'm still on 2.6.33.5-rt22 on powerpc, and have run into a couple > > > "sleeping function called from invalid context..." BUGs. The > first was > > > during system boot, second during a 'make'. > > > > > > relevant code paths don't seem to have changed between -rt22 and > -rt23, > > > so I think still valid.. :-) > > > > > > This is on a POWER7 system, which may have opened up some timing > > > windows, wrt previous runs on POWER6 systems. > > > > > > > > > BUG: sleeping function called from invalid context at > > > kernel/rtmutex.c:684 > > > > > [c000000078cf2cf0] [c000000000131a04] .irq_to_desc_alloc_node > +0xdc/0x2b8 > > > > Grr. I thought I had the SPARSE_IRQ stuff disabled on -rt, but seems > > it came back somehow. Can you disable that, or does you machine > depend > > on it ? > > I'm not sure whether it is required by the architecture. I do see > that > SPARSE_IRQ is disabled in arch/x86/Kconfig with a !PREEMPT_RT, but I > don't see an equivalent 'disable' in arch/powerpc/Kconfig. > I see it as "y" in my .config for a powerpc 405 build. This appears to run on my system (although I haven't loaded up the rt23 build on the target yet - last one loaded up was rt22). What should I expect to see different if SPARSE_IRQ is turned off? > > > > BUG: sleeping function called from invalid context at > kernel/rtmutex.c:684 > > > pcnt: 0 0 in_atomic(): 0, irqs_disabled(): 1, pid: 4760, name: > make > > > Call Trace: > > > [c0000000792978b0] [c000000000015550] .show_stack+0xd8/0x218 > (unreliable) > > > [c000000079297990] [c0000000006a99c8] .dump_stack+0x28/0x3c > > > [c000000079297a10] [c00000000006cea8] .__might_sleep+0x134/0x15c > > > [c000000079297ab0] [c0000000006a2f78] .rt_spin_lock+0x4c/0x9c > > > [c000000079297b40] [c0000000000a1ff0] .get_signal_to_deliver > +0xcc/0x4ec > > > [c000000079297c50] [c000000000018604] .do_signal_pending.clone.0 > +0x6c/0x2e0 > > > [c000000079297d90] [c0000000000188b0] .do_signal+0x38/0x74 > > > [c000000079297e30] [c000000000008b40] user_work+0x24/0x28 > > > > Does the patch below fix it ? > > Probably.. :-) I'm running with the patch now, and no repeats of > that > BUG yet. > > Thanks, > -Will > > > > > > Thanks, > > > > tglx > > ----- > > diff --git a/arch/powerpc/kernel/signal.c > b/arch/powerpc/kernel/signal.c > > index 00b5078..fa580f9 100644 > > --- a/arch/powerpc/kernel/signal.c > > +++ b/arch/powerpc/kernel/signal.c > > @@ -120,6 +120,14 @@ static int do_signal_pending(sigset_t *oldset, > struct pt_regs *regs) > > int ret; > > int is32 = is_32bit_task(); > > > > +#ifdef CONFIG_PREEMPT_RT > > + /* > > + * Fully-preemptible kernel does not need interrupts disabled: > > + */ > > + local_irq_enable(); > > + preempt_check_resched(); > > +#endif > > + > > if (current_thread_info()->local_flags & _TLF_RESTORE_SIGMASK) > > oldset = ¤t->saved_sigmask; > > else if (!oldset) > > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-rt-users" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Thomas Gleixner on 14 Jun 2010 09:40 On Thu, 10 Jun 2010, Will Schmidt wrote: > On Thu, 2010-06-10 at 08:07 +0200, Thomas Gleixner wrote: > > On Wed, 9 Jun 2010, Will Schmidt wrote: > > > > > On Wed, 2010-06-09 at 18:44 +0200, Thomas Gleixner wrote: > > > I'm still on 2.6.33.5-rt22 on powerpc, and have run into a couple > > > "sleeping function called from invalid context..." BUGs. The first was > > > during system boot, second during a 'make'. > > > > > > relevant code paths don't seem to have changed between -rt22 and -rt23, > > > so I think still valid.. :-) > > > > > > This is on a POWER7 system, which may have opened up some timing > > > windows, wrt previous runs on POWER6 systems. > > > > > > > > > BUG: sleeping function called from invalid context at > > > kernel/rtmutex.c:684 > > > > > [c000000078cf2cf0] [c000000000131a04] .irq_to_desc_alloc_node+0xdc/0x2b8 > > > > Grr. I thought I had the SPARSE_IRQ stuff disabled on -rt, but seems > > it came back somehow. Can you disable that, or does you machine depend > > on it ? > > I'm not sure whether it is required by the architecture. I do see that > SPARSE_IRQ is disabled in arch/x86/Kconfig with a !PREEMPT_RT, but I > don't see an equivalent 'disable' in arch/powerpc/Kconfig. Can you disable it ? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Next
|
Last
Pages: 1 2 Prev: [PATCH] MAINTAINERS: Add file patterns to UCLINUX FOR RENESAS H8/300 Next: Confirm: |