Prev: [regression] Fails to boot properly unless given pci=nocrs
Next: x86: Reserve legacy VGA MMIO area for x86_64 as well as x86_32
From: John W. Linville on 7 Apr 2010 18:10
On Wed, Apr 07, 2010 at 11:08:30PM +0200, Rafael J. Wysocki wrote:

> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15551
> Subject : WARNING: at net/mac80211/work.c:811 ieee80211_work_work+0x7f/0xde8 [mac80211]()
> Submitter : Alex Zhavnerchik <alex.vizor(a)gmail.com>
> Date : 2010-03-16 22:03 (23 days old)

I sent a pull request with the patch for this to Dave M. today. :-)

John
--
John W. Linville Someday the world will need a hero, and you
linville(a)tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on 7 Apr 2010 18:30


On Wed, 7 Apr 2010, Al Viro wrote:
>
> No, it's not the same thing; the fix is to have nfs ->d_revalidate()
> return an error on failing open attempt (in insane codepath that has
> ->d_revalidate() handling open()). Confirmed to work by reporter...

Ok, can you do the proper changelog description and sign-offs etc?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Al Viro on 7 Apr 2010 19:10
On Wed, Apr 07, 2010 at 03:22:20PM -0700, Linus Torvalds wrote:
>
>
> On Wed, 7 Apr 2010, Al Viro wrote:
> >
> > No, it's not the same thing; the fix is to have nfs ->d_revalidate()
> > return an error on failing open attempt (in insane codepath that has
> > ->d_revalidate() handling open()). Confirmed to work by reporter...
>
> Ok, can you do the proper changelog description and sign-offs etc?

[PATCH] Have nfs ->d_revalidate() report errors properly

If nfs atomic open implementation ends up doing open request from
->d_revalidate() codepath and gets an error from server, return that error
to caller explicitly and don't bother with lookup_instantiate_filp() at all.
->d_revalidate() can return an error itself just fine...

Signed-off-by: Al Viro <viro(a)zeniv.linux.org.uk>
---
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index d79a7b3..fe0cd9e 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -2068,8 +2068,7 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st
case -EDQUOT:
case -ENOSPC:
case -EROFS:
- lookup_instantiate_filp(nd, (struct dentry *)state, NULL);
- return 1;
+ return PTR_ERR(state);
default:
goto out_drop;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [regression] Fails to boot properly unless given pci=nocrs
Next: x86: Reserve legacy VGA MMIO area for x86_64 as well as x86_32