Prev: [08/39] ALSA: hda - fix DG45ID SPDIF output
Next: [24/39] inotify: race use after free/double free in inotify inode marks
From: Greg KH on 24 May 2010 19:30

2.6.33-stable review patch. If anyone has any objections, please let us know.

------------------
From: Alan Cox <alan(a)linux.intel.com>

commit 77945febbe60a69e9dcab7f49d33a1aa1e436973 upstream.

Arnd noted:

After the "retry_open:" label, we first get the tty_mutex
and then the BKL. However a the end of tty_open, we jump
back to retry_open with the BKL still held. If we run into
this case, the tty_open function will be left with the BKL
still held.

Signed-off-by: Alan Cox <alan(a)linux.intel.com>
Acked-by: Arnd Bergmann <arnd(a)arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
drivers/char/tty_io.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -1875,6 +1875,7 @@ got_driver:
*/
if (filp->f_op == &hung_up_tty_fops)
filp->f_op = &tty_fops;
+ unlock_kernel();
goto retry_open;
}
unlock_kernel();


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [08/39] ALSA: hda - fix DG45ID SPDIF output
Next: [24/39] inotify: race use after free/double free in inotify inode marks