[4/4] SLAB: Fix node add timer race in cache_reap
in [Kernel]
|
Prev: X11 is black after resume from s2ram if my T400 was previous in docking station before
Next: [PATCHv4 1/2] sched: enable ARCH_POWER
From: Andi Kleen on 20 Feb 2010 04:10 On Fri, Feb 19, 2010 at 12:22:58PM -0600, Christoph Lameter wrote: > On Mon, 15 Feb 2010, Nick Piggin wrote: > > > I'm just worried there is still an underlying problem here. > > So am I. What caused the breakage that requires this patchset? Memory hotadd with a new node being onlined. -Andi -- ak(a)linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 22 Feb 2010 06:00 Andi Kleen kirjoitti: > On Fri, Feb 19, 2010 at 12:22:58PM -0600, Christoph Lameter wrote: >> On Mon, 15 Feb 2010, Nick Piggin wrote: >> >>> I'm just worried there is still an underlying problem here. >> So am I. What caused the breakage that requires this patchset? > > Memory hotadd with a new node being onlined. So can you post the oops, please? Right now I am looking at zapping the series from slab.git due to NAKs from both Christoph and Nick. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 22 Feb 2010 06:00 Christoph Lameter kirjoitti: > On Mon, 15 Feb 2010, Andi Kleen wrote: > >>> How, may I ask? cpuup_prepare in the hotplug notifier should always >>> run before start_cpu_timer. >> I'm not fully sure, but I have the oops to prove it :) > > I still suspect that this has something to do with Pekka's changing the > boot order for allocator bootstrap. Can we clarify why these problems > exist before we try band aid? I don't see how my changes broke things but maybe I'm not looking hard enough. Cache reaping is still setup from cpucache_init() which is an initcall which is not affected by my changes AFAICT and from cpuup_callback() which shoulda also not be affected. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andi Kleen on 22 Feb 2010 09:40 On Mon, Feb 22, 2010 at 12:53:27PM +0200, Pekka Enberg wrote: > Andi Kleen kirjoitti: >> On Fri, Feb 19, 2010 at 12:22:58PM -0600, Christoph Lameter wrote: >>> On Mon, 15 Feb 2010, Nick Piggin wrote: >>> >>>> I'm just worried there is still an underlying problem here. >>> So am I. What caused the breakage that requires this patchset? >> >> Memory hotadd with a new node being onlined. > > So can you post the oops, please? Right now I am looking at zapping the I can't post the oops from a pre-release system. > series from slab.git due to NAKs from both Christoph and Nick. Huh? They just complained about the patch, not the whole series. I don't understand how that could prompt you to drop the whole series. As far as I know nobody said the patch is wrong so far, just that they wanted to have more analysis. -Andi -- ak(a)linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 22 Feb 2010 11:20
Andi Kleen wrote: > On Mon, Feb 22, 2010 at 12:53:27PM +0200, Pekka Enberg wrote: >> Andi Kleen kirjoitti: >>> On Fri, Feb 19, 2010 at 12:22:58PM -0600, Christoph Lameter wrote: >>>> On Mon, 15 Feb 2010, Nick Piggin wrote: >>>> >>>>> I'm just worried there is still an underlying problem here. >>>> So am I. What caused the breakage that requires this patchset? >>> Memory hotadd with a new node being onlined. >> So can you post the oops, please? Right now I am looking at zapping the > > I can't post the oops from a pre-release system. > >> series from slab.git due to NAKs from both Christoph and Nick. > > Huh? They just complained about the patch, not the whole series. > I don't understand how that could prompt you to drop the whole series. Yeah, I meant the non-ACK'd patches. Sorry for the confusion. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |