Prev: [89/93] mac80211: Fix probe request filtering in IBSS mode
Next: [60/93] devmem: fix kmem write bug on memory holes
From: Greg KH on 19 Feb 2010 12:10
2.6.32-stable review patch. If anyone has any objections, please let us know.

------------------

From: Eric Dumazet <eric.dumazet(a)gmail.com>

commit 2fc1b5dd99f66d93ffc23fd8df82d384c1a354c8 upstream.

Kernel bugzilla #15239

On some workloads, it is quite possible to get a huge dst list to
process in dst_gc_task(), and trigger soft lockup detection.

Fix is to call cond_resched(), as we run in process context.

Reported-by: Pawel Staszewski <pstaszewski(a)itcare.pl>
Tested-by: Pawel Staszewski <pstaszewski(a)itcare.pl>
Signed-off-by: Eric Dumazet <eric.dumazet(a)gmail.com>
Signed-off-by: David S. Miller <davem(a)davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
net/core/dst.c | 2 ++
1 file changed, 2 insertions(+)

--- a/net/core/dst.c
+++ b/net/core/dst.c
@@ -17,6 +17,7 @@
#include <linux/string.h>
#include <linux/types.h>
#include <net/net_namespace.h>
+#include <linux/sched.h>

#include <net/dst.h>

@@ -79,6 +80,7 @@ loop:
while ((dst = next) != NULL) {
next = dst->next;
prefetch(&next->next);
+ cond_resched();
if (likely(atomic_read(&dst->__refcnt))) {
last->next = dst;
last = dst;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [89/93] mac80211: Fix probe request filtering in IBSS mode
Next: [60/93] devmem: fix kmem write bug on memory holes