Prev: X86:reboot.c Add some dmi entries to pci_reboot_dmi_table.
Next: udf:super.c Fix warning: variable 'sbi' set but not used
From: Dan Carpenter on 31 Jul 2010 15:10
On Sat, Jul 31, 2010 at 09:38:00PM +0400, Kulikov Vasiliy wrote:
> - sizeof(struct m68k_serial)))
> - return -EFAULT;
> - copy_to_user((struct m68k_serial *) arg,
> + return copy_to_user((struct m68k_serial *) arg,
> info, sizeof(struct m68k_serial));

We should return if -EFAULT copy_to_user() failes here.

> - return 0;
> -
> default:
> return -ENOIOCTLCMD;
> }

Smatch would have caught that but I don't have a cross compile
environment set up.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: X86:reboot.c Add some dmi entries to pci_reboot_dmi_table.
Next: udf:super.c Fix warning: variable 'sbi' set but not used