Prev: [72/93] x86/amd-iommu: Fix deassignment of a device from the pt_domain
Next: [59/93] devmem: check vmalloc address on kmem read/write
From: Greg KH on 19 Feb 2010 12:10
2.6.32-stable review patch. If anyone has any objections, please let us know.

------------------

From: Nikanth Karthikesan <knikanth(a)suse.de>

commit 781248c1b50c776a9ef4be1130f84ced1cba42fe upstream.

If a table containing zero as stripe count is passed into stripe_ctr
the code attempts to divide by zero.

This patch changes DM_TABLE_LOAD to return -EINVAL if the stripe count
is zero.

We now get the following error messages:
device-mapper: table: 253:0: striped: Invalid stripe count
device-mapper: ioctl: error adding target to table

Signed-off-by: Nikanth Karthikesan <knikanth(a)suse.de>
Signed-off-by: Alasdair G Kergon <agk(a)redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
drivers/md/dm-stripe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/md/dm-stripe.c
+++ b/drivers/md/dm-stripe.c
@@ -110,7 +110,7 @@ static int stripe_ctr(struct dm_target *
}

stripes = simple_strtoul(argv[0], &end, 10);
- if (*end) {
+ if (!stripes || *end) {
ti->error = "Invalid stripe count";
return -EINVAL;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [72/93] x86/amd-iommu: Fix deassignment of a device from the pt_domain
Next: [59/93] devmem: check vmalloc address on kmem read/write