ACPI: Protection from suspending in the middle of EC transaction
in [Kernel]
|
Prev: [PATCH 6/7] atm: Use for_each_bit
Next: [2.6.33-rc6] should B.A.T.M.A.N. mesh be an option without wlan?
From: Alan Jenkins on 31 Jan 2010 09:20 On 1/30/10, Rafael J. Wysocki <rjw(a)sisk.pl> wrote: > Hi, > > While Maxim is testing if the patch below helps with > http://bugzilla.kernel.org/show_bug.cgi?id=14668 > I think it's necessary anyway. > > The problem is that currently there's nothing to prevent us from suspending > in > the middle of an EC transaction in progress, at least as far as I can see. > As a result, we can suspend with the ACPI global lock held or something like > this, which leads to problems especially for hibernation (if the resume > kernel > passes control to the image kernel in the middle of an EC transaction, > things > aren't nice). For this reason I think we should wait until there are no EC > transactions in progress before we suspend and we should prevent any new > EC transactions from starting after that point. The patch below does that. I also believe this is a problem. I reported the following - <http://bugzilla.kernel.org/show_bug.cgi?id=14112> "Pressing acpi hotkeys duing hibernation may occasionally cause EC transaction timeout" and posted a patch, but I couldn't reproduce my specific issue in order to confirm that the patch helped. Regards Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |