ACPI: Use GPE reference counting to support shared GPEs
in [Kernel]
|
Prev: NO_HZ migration of TCP ack timers
Next: acpi: Fix regression where _PPC is not read at boot even when ignore_ppc=0
From: Jin Dongming on 18 Feb 2010 02:10 Hi, Rafael J. Wysocki > - /* Update enable mask, but don't enable the HW GPE as of yet */ > - > - status = acpi_ev_enable_gpe(gpe_event_info, FALSE); I think the above line code should be remained. If it is deleted, the exception event will be raised on some machine. Best Regards, Jin Dongming > - > ACPI_DEBUG_PRINT((ACPI_DB_LOAD, > "Registered GPE method %s as GPE number 0x%.2X\n", > name, gpe_number)); > - return_ACPI_STATUS(status); > + return_ACPI_STATUS(AE_OK); > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jin Dongming on 19 Feb 2010 02:30
Hi, Rafael J. Wysocki Rafael J. Wysocki wrote: > On Thursday 18 February 2010, Jin Dongming wrote: >> Hi, Rafael J. Wysocki >>> - /* Update enable mask, but don't enable the HW GPE as of yet */ >>> - >>> - status = acpi_ev_enable_gpe(gpe_event_info, FALSE); > > You could preserve some more context. > >> I think the above line code should be remained. If it is deleted, the exception >> event will be raised on some machine. > > Why would it? The GPE is still disabled at the hardware level at this point. > > Rafael > > I am very sorry for my wrong comment. The GPE is still disabled as you wrote. The error message what I got was not caused by GPE event, it was caused by the "status" variable which had not been deleted on x86-next tree. And it is also deleted at this file. So I don't there is problem here. Best regards, Jin Dongming -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |