AMD errata checking framework
in [Kernel]
|
Prev: [GIT] Networking
Next: [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.
From: H. Peter Anvin on 11 Jun 2010 16:20 On 06/11/2010 06:25 AM, Hans Rosenfeld wrote: > + if (static_cpu_has(X86_FEATURE_OSVW) && static_cpu_has() is only well-defined for code that is only executed after alternatives execution; that would not seem to be the case for this code. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Hans Rosenfeld on 14 Jun 2010 08:40 On Fri, Jun 11, 2010 at 04:14:31PM -0400, H. Peter Anvin wrote: > On 06/11/2010 06:25 AM, Hans Rosenfeld wrote: > > + > > +/* > > + * Check for the presence of an AMD erratum. > > + * Arguments are defined in processor.h for each known erratum. > > + */ > > +bool cpu_has_amd_erratum(const struct cpuinfo_x86 *cpu, bool osvw, ...) > > +{ > > /home/hpa/kernel/linux-2.6-tip.cpu/arch/x86/kernel/cpu/amd.c: In > function ?cpu_has_amd_erratum?: > /home/hpa/kernel/linux-2.6-tip.cpu/arch/x86/kernel/cpu/amd.c:635: error: > expected expression before ?do? > /home/hpa/kernel/linux-2.6-tip.cpu/arch/x86/kernel/cpu/amd.c:636: error: > expected expression before ?do? > /home/hpa/kernel/linux-2.6-tip.cpu/arch/x86/kernel/cpu/amd.c:632: > warning: unused variable ?t? Umpf. It seems like I underestimated the brokenness of rdmsrl() etc.. A new patch set will follow shortly. I also added va_end() calls where necessary and replaced static_cpu_has() with cpu_has(). > Also, the use of divide and modulo when shifts and masks work are > generally frowned upon in Linux as a matter of style. While I agree in principle, I think that in this special case the divide and modulo by 64 make it easier to understand what the code does on the first look. But if you insist I will send another patch set that replaces divide and modulo with shifts and masks. Hans -- %SYSTEM-F-ANARCHISM, The operating system has been overthrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 15 Jun 2010 14:20
On 06/14/2010 05:33 AM, Hans Rosenfeld wrote: > >> Also, the use of divide and modulo when shifts and masks work are >> generally frowned upon in Linux as a matter of style. > > While I agree in principle, I think that in this special case the > divide and modulo by 64 make it easier to understand what the code > does on the first look. But if you insist I will send another patch > set that replaces divide and modulo with shifts and masks. > I do insist. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |