Add DMI quirk for Intel DP55KG mainboard
in [Kernel]
|
Prev: Linux* is not supported on the Intel(R) Desktop Board DP55KG - Kernel still hangs upon reboot.
Next: drm: add KGDB/KDB support Add support for KDB entry/exit.
From: Len Brown on 4 Jan 2010 12:20 On Mon, 4 Jan 2010, Christian Hofstaedtler wrote: > From: Christian Hofstaedtler <ch+git(a)zeha.at> > > The Intel DP55KG mainboard cannot reboot using the keyboard controller, > but ACPI works fine. Auto-select ACPI for this board. > > Signed-off-by: Christian Hofstaedtler <ch(a)zeha.at> > --- > arch/x86/kernel/reboot.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c > index 1545bc0..b7fcf59 100644 > --- a/arch/x86/kernel/reboot.c > +++ b/arch/x86/kernel/reboot.c > @@ -427,6 +427,19 @@ static int __init set_pci_reboot(const struct dmi_system_id *d) > return 0; > } > > +/* > + * Some Intel mainboards need reboot=a to actually reboot > + */ > +static int __init set_acpi_reboot(const struct dmi_system_id *d) > +{ > + if (reboot_type != BOOT_ACPI) { > + reboot_type = BOOT_ACPI; > + printk(KERN_INFO "%s hardware detected. " > + "Selecting ACPI-method for reboots.\n", d->ident); > + } > + return 0; > +} > + > static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { > { /* Handle problems with rebooting on Apple MacBook5 */ > .callback = set_pci_reboot, > @@ -452,6 +465,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Macmini3,1"), > }, > }, > + { /* Handle problems with rebooting on Intel DP55KG mainboard */ > + .callback = set_acpi_reboot, > + .ident = "Intel DP55KG Mainboard", > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "Intel Corporation"), > + DMI_MATCH(DMI_BOARD_NAME, "DP55KG"), > + }, > + }, > { } > }; > > -- > 1.6.4.4 I believe that Venki is sending a patch to make all recent motherboards use acpi reset by default; and I'd rather see that kind of patch than this one. I've had the patch below patch in acpi-test, and thus linus-next, and -mm since Nov 2008 to change the default for all systems w/ no issues. commit 2cb758c617833c18c533e1c4c31167e59d092235 Author: Len Brown <len.brown(a)intel.com> Date: Thu Nov 6 22:43:21 2008 -0500 x86, ACPI: default to reboot via ACPI (again) We've run into systems which do not reboot properly without using the ACPI reset mechanism. So lets try this in linux-next for a while and see how many existing machines stop rebooting because they can't handle ACPI reboot. Signed-off-by: Len Brown <len.brown(a)intel.com> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index d2d1ce8..4c53aeb 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -32,7 +32,7 @@ EXPORT_SYMBOL(pm_power_off); static const struct desc_ptr no_idt = {}; static int reboot_mode; -enum reboot_type reboot_type = BOOT_KBD; +enum reboot_type reboot_type = BOOT_ACPI; int reboot_force; #if defined(CONFIG_X86_32) && defined(CONFIG_SMP) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 4 Jan 2010 12:40 On 01/04/2010 09:15 AM, Len Brown wrote: > > I believe that Venki is sending a patch to make all recent > motherboards use acpi reset by default; and I'd rather > see that kind of patch than this one. > > I've had the patch below patch in acpi-test, and thus linus-next, > and -mm since Nov 2008 to change the default for > all systems w/ no issues. > Maybe I'm misremembering, but didn't we have to pull this patch after it hit mainstream the last time? -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Len Brown on 4 Jan 2010 17:10 > > I believe that Venki is sending a patch to make all recent > > motherboards use acpi reset by default; and I'd rather > > see that kind of patch than this one. > > > > I've had the patch below patch in acpi-test, and thus linus-next, > > and -mm since Nov 2008 to change the default for > > all systems w/ no issues. > > > > Maybe I'm misremembering, but didn't we have to pull this patch after it > hit mainstream the last time? c7ffa6c26277b403920e2255d10df849bd613380 "x86: default to reboot via ACPI" set ACPI as the default in 2.6.28-rc1 8d00450d296dedec9ada38d43b83e79cca6fd5a3 Revert "x86: default to reboot via ACPI" pulled it in v2.6.28-rc4 The original patch was justified by VMX support, and the revert was in response to Andrey Borzenkov's DMI patch to usee BIOS reset on his Toshiba Porgege 4000: http://lkml.org/lkml/2008/10/31/242 The Toshiba Portege 4000 shipped in early 2002. The patch to restore ACPI reset to default has been in Linux-next (with occasional drops) since the day it was dropped from 2.6.28-rc4. As we have an existence proof, I have no doubt that using ACPI reset by default will un-earth some regressions. However, my guess is that the DMI list of old machines that will fail with ACPI reset will be smaller than by the DMI list of brand-new machines that will fail without ACPI reset. We couuld use a DMI year cut-off as we do with ACPI itself CONFIG_ACPI_BLACKLIST_YEAR, though that doesn't work on systems that don't have DMI... If I were to propose a year, I'd say 2006 and newer, since XP was "Windows 2006". thanks, Len Brown, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arjan van de Ven on 4 Jan 2010 20:50 On Mon, 04 Jan 2010 09:30:27 -0800 "H. Peter Anvin" <hpa(a)zytor.com> wrote: > On 01/04/2010 09:15 AM, Len Brown wrote: > > > > I believe that Venki is sending a patch to make all recent > > motherboards use acpi reset by default; and I'd rather > > see that kind of patch than this one. > > > > I've had the patch below patch in acpi-test, and thus linus-next, > > and -mm since Nov 2008 to change the default for > > all systems w/ no issues. > > > > Maybe I'm misremembering, but didn't we have to pull this patch after > it hit mainstream the last time? can we do it based on the dmi/acpi year? Eg for all 2008 and later machines or something, while leaving the older ones as is -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Robert Hancock on 4 Jan 2010 21:20
On 01/04/2010 04:03 PM, Len Brown wrote: >>> I believe that Venki is sending a patch to make all recent >>> motherboards use acpi reset by default; and I'd rather >>> see that kind of patch than this one. >>> >>> I've had the patch below patch in acpi-test, and thus linus-next, >>> and -mm since Nov 2008 to change the default for >>> all systems w/ no issues. >>> >> >> Maybe I'm misremembering, but didn't we have to pull this patch after it >> hit mainstream the last time? > > > c7ffa6c26277b403920e2255d10df849bd613380 > "x86: default to reboot via ACPI" > > set ACPI as the default in 2.6.28-rc1 > > 8d00450d296dedec9ada38d43b83e79cca6fd5a3 > Revert "x86: default to reboot via ACPI" > > pulled it in v2.6.28-rc4 > > The original patch was justified by VMX support, > and the revert was in response to Andrey Borzenkov's > DMI patch to usee BIOS reset on his Toshiba Porgege 4000: > > http://lkml.org/lkml/2008/10/31/242 > > The Toshiba Portege 4000 shipped in early 2002. > > The patch to restore ACPI reset to default has been in Linux-next > (with occasional drops) since the day it was dropped from 2.6.28-rc4. > > As we have an existence proof, I have no doubt that using > ACPI reset by default will un-earth some regressions. However, > my guess is that the DMI list of old machines that will fail > with ACPI reset will be smaller than by the DMI list of > brand-new machines that will fail without ACPI reset. > > We couuld use a DMI year cut-off as we do with > ACPI itself CONFIG_ACPI_BLACKLIST_YEAR, though that > doesn't work on systems that don't have DMI... > If I were to propose a year, I'd say 2006 and newer, > since XP was "Windows 2006". Think you mean 2001, Vista was 2006.. I'm assuming that Windows is using ACPI reset these days, so presumably that's what we should be doing by default, and blacklisting machines where that doesn't work, rather than the reverse.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |