Add comment in alloc_pages_exact_node
in [Kernel]
|
Prev: [PATCH 2.6.34-rc4 3/8] mxc: Add platform specific USB functions for Freescale MX51 HW
Next: mxc: Update GPIO for USB support on Freescale MX51 Babbage HW
From: Mel Gorman on 13 Apr 2010 12:20 On Wed, Apr 14, 2010 at 12:25:03AM +0900, Minchan Kim wrote: > alloc_pages_exact_node naming makes some people misleading. > They considered it following as. > "This function will allocate pages from node which I wanted > exactly". > But it can allocate pages from fallback list if page allocator > can't find free page from node user wanted. > > So let's comment this NOTE. > It's a little tough to read. How about /* * Use this instead of alloc_pages_node when the caller knows * exactly which node they need (as opposed to passing in -1 * for current). Fallback to other nodes will still occur * unless __GFP_THISNODE is specified. */ That at least will tie in why "exact" is in the name? > Actually I wanted to change naming with better. > ex) alloc_pages_explict_node. "Explicit" can also be taken to mean "this and only this node". > But I changed my mind since the comment would be enough. > > If anybody suggests better name, I will do with pleasure. > > Cc: Mel Gorman <mel(a)csn.ul.ie> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> > Cc: Bob Liu <lliubbo(a)gmail.com> > Signed-off-by: Minchan Kim <minchan.kim(a)gmail.com> > --- > include/linux/gfp.h | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index b65f003..7539c17 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -288,6 +288,11 @@ static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask, > return __alloc_pages(gfp_mask, order, node_zonelist(nid, gfp_mask)); > } > > +/* > + * NOTE : Allow page from fallback if page allocator can't find free page > + * in your nid. Only if you want to allocate page from your nid, use > + * __GFP_THISNODE flags with gfp_mask. > + */ > static inline struct page *alloc_pages_exact_node(int nid, gfp_t gfp_mask, > unsigned int order) > { > -- > 1.7.0.5 > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Minchan Kim on 13 Apr 2010 12:30
On Wed, Apr 14, 2010 at 1:13 AM, Mel Gorman <mel(a)csn.ul.ie> wrote: > On Wed, Apr 14, 2010 at 12:25:03AM +0900, Minchan Kim wrote: >> alloc_pages_exact_node naming makes some people misleading. >> They considered it following as. >> "This function will allocate pages from node which I wanted >> exactly". >> But it can allocate pages from fallback list if page allocator >> can't find free page from node user wanted. >> >> So let's comment this NOTE. >> > > It's a little tough to read. How about > > /* > * Use this instead of alloc_pages_node when the caller knows > * exactly which node they need (as opposed to passing in -1 > * for current). Fallback to other nodes will still occur > * unless __GFP_THISNODE is specified. > */ It is better than mine. > > That at least will tie in why "exact" is in the name? > >> Actually I wanted to change naming with better. >> ex) alloc_pages_explict_node. > > "Explicit" can also be taken to mean "this and only this node". I agree. I will repost modified comment after Tejun comment [2/6]. Thanks for quick review, Mel. :) -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |