Added locks for sysfs attributes and internal data.
in [Kernel]
|
Prev: i2c: update for semaphore to mutex conversion of devices
Next: [BUGFIX][PATCH] fix sync_mm_rss in nommu (Was Re: sync_mm_rss() issues
From: Jiri Kosina on 8 Mar 2010 19:10 On Mon, 8 Mar 2010, Stefan Achatz wrote: > From 47678162da8e374d6f132db21d89b718ee5cfbd1 Mon Sep 17 00:00:00 2001 > From: Stefan Achatz <erazor_de(a)users.sourceforge.net> > Date: Mon, 8 Mar 2010 16:54:19 +0100 > Subject: [PATCH 4/4] Added locks for sysfs attributes and internal data. > > Added mutex lock to prevent different processes from accessing > sysfs attributes at the same time. > Added spin lock for internal data. > --- > drivers/hid/hid-roccat-kone.c | 246 ++++++++++++++++++++++++++++------------ > drivers/hid/hid-roccat-kone.h | 9 +- > 2 files changed, 179 insertions(+), 76 deletions(-) Stefan, could you please submit the rest of the patch series as well? I seem to have got only "4/4" patch of your series, but not the rest of the roccat driver (I recall there were some review comments raised after your initial submission of the driver, so full respin would be appreciated). Also, please don't forget to put proper Signed-off-by: lines to the patches you submit with intention for upstream merge. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Kosina on 15 Mar 2010 10:00
On Sun, 14 Mar 2010, Dmitry Torokhov wrote: > > 3. grow up of driver > > I see my work is not quite ready for kernel inclusion. Maybe I'm wrong in this > > list and should bug other people. Would the linuxdriverproject.org be a > > better place to raise my work to adulthood? > > > Rarely a driver is ready for inclusion right away ;) Normally that > happens after someone submitted a few of them to the same subsystem so > he knows maintainers perferences, etc. I'd say you are doing well as is > here, there is no sense to move away somewhere else at this point. Absolutely. Stefan, you are handling the review feedback in an excellent way, and the driver is very quickly getting into shape in which it would be merge-able right away. So please do another round of submission with all the concerns that have been raised previously addressed, and I believe I'll just apply the driver to my tree. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |