Archive recovery crashes on win32 in HEAD - hot standby related?
in [PgSql]
|
From: Robert Haas on 16 Jan 2010 08:28 On Sat, Jan 16, 2010 at 8:19 AM, Magnus Hagander <magnus(a)hagander.net> wrote: > Not knowing that code very well at this time, but is this perhaps a > structure not being properly initialized in EXEC_BACKEND case? It looks like KnownAssignedXidsHash is not initialized. That's supposed to happen when CreateSharedProcArray calls KnownAssignedXidsInit, but that only happens for the first process to call that function... but without EXEC_BACKEND it'll just work anyway. ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 16 Jan 2010 11:10 Robert Haas <robertmhaas(a)gmail.com> writes: > On Sat, Jan 16, 2010 at 8:19 AM, Magnus Hagander <magnus(a)hagander.net> wrote: >> Not knowing that code very well at this time, but is this perhaps a >> structure not being properly initialized in EXEC_BACKEND case? > It looks like KnownAssignedXidsHash is not initialized. That's > supposed to happen when CreateSharedProcArray calls > KnownAssignedXidsInit, but that only happens for the first process to > call that function... but without EXEC_BACKEND it'll just work anyway. That code is completely broken as far as the division of labor between "first" and not "first" is concerned ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 16 Jan 2010 12:18 Magnus Hagander <magnus(a)hagander.net> writes: > I was going to test the walreceiver stuff, but it turns out that basic > archive recovery appears to be broken in HEAD. From what I can tell, > it's related to Hot Standby code. I've committed a fix that makes it work in EXEC_BACKEND case on Unix. Can't tell if there are any Windows-specific issues. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 17 Jan 2010 07:56 2010/1/16 Tom Lane <tgl(a)sss.pgh.pa.us>: > Magnus Hagander <magnus(a)hagander.net> writes: >> I was going to test the walreceiver stuff, but it turns out that basic >> archive recovery appears to be broken in HEAD. From what I can tell, >> it's related to Hot Standby code. > > I've committed a fix that makes it work in EXEC_BACKEND case on Unix. > Can't tell if there are any Windows-specific issues. Seems to have worked - I can confirm I can now do archive recovery again. Seems streaming replication is broken though, rebuilding a debug build to see if I can figure out why. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
|
Pages: 1 Prev: Mammoth in Core? Next: [COMMITTERS] pgsql: Fix one more cast for _open_osfhandle(). |