Prev: drivers/net/smc911x.c: use %pM to shown MAC address
Next: [PATCH] mm: move sys_mmap_pgoff from util.c
From: Peter Paul on 30 Dec 2009 15:10
Broadcom has just released a linux driver for their BCM70012 and BCM70015 Crystal HD High Definition video decoders under the GPLv2 licence. [1]
Maybe you want to have a look at them.

[1] http://www.broadcom.com/support/crystal_hd/
___________________________________________________________
Preisknaller: WEB.DE DSL Flatrate f�r nur 16,99 Euro/mtl.!
http://produkte.web.de/go/02/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Andrey Panin on 31 Dec 2009 08:30
On 364, 12 30, 2009 at 09:06:15PM +0100, Peter Paul wrote:
> Broadcom has just released a linux driver for their BCM70012 and BCM70015 Crystal HD High Definition video decoders under the GPLv2 licence. [1]
> Maybe you want to have a look at them.
>
> [1] http://www.broadcom.com/support/crystal_hd/

From quick inspection kernel part looks much better than most vendor-provided
drivers. It needs some cleanups and bugfixes, for example error handling in
device probe function doesn't look right to me, driver can't handle more than
one device as far as I can see (I don't know is it really needed though), etc.
But anyway this driver definitely deserves putting into staging.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 2 Jan 2010 01:10
On Thu, Dec 31, 2009 at 04:18:52PM +0300, Andrey Panin wrote:
> On 364, 12 30, 2009 at 09:06:15PM +0100, Peter Paul wrote:
> > Broadcom has just released a linux driver for their BCM70012 and BCM70015 Crystal HD High Definition video decoders under the GPLv2 licence. [1]
> > Maybe you want to have a look at them.
> >
> > [1] http://www.broadcom.com/support/crystal_hd/
>
> >From quick inspection kernel part looks much better than most vendor-provided
> drivers. It needs some cleanups and bugfixes, for example error handling in
> device probe function doesn't look right to me, driver can't handle more than
> one device as far as I can see (I don't know is it really needed though), etc.
> But anyway this driver definitely deserves putting into staging.

I'm glad to do so if someone wants to help work on it there and shephard
it into the main kernel tree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 2 Jan 2010 11:50
On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote:
> Hi Greg,
>
> > I'm glad to do so if someone wants to help work on it there and shephard
> > it into the main kernel tree.
>
> Please find the initial round of cleaned up patches for staging,
> applied against linux-next.

Did you really author this driver? If so, that's fine, just checking.
If not, please put the correct authorship "From:" in the patch.

Also, please break up patches to be sent one-per-email so they can be
properly applied, and also only have them do one thing (your 4th patch
fixed up coding style issues and added the driver to the build.)

Also, can you add a TODO file to the driver directory stating what is
needed to be done, and who to contact about it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Manu Abraham on 2 Jan 2010 13:20
Hi Greg,

On Sat, Jan 2, 2010 at 8:34 PM, Greg KH <greg(a)kroah.com> wrote:
> On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote:
>> Hi Greg,
>>
>> > I'm glad to do so if someone wants to help work on it there and shephard
>> > it into the main kernel tree.
>>
>> Please find the initial round of cleaned up patches for staging,
>> applied against linux-next.
>
> Did you really author this driver? �If so, that's fine, just checking.
> If not, please put the correct authorship "From:" in the patch.

I am not the author of the driver. I just picked it up and cleaned it
up for Coding style changes for it to be included.

> Also, please break up patches to be sent one-per-email so they can be
> properly applied, and also only have them do one thing (your 4th patch
> fixed up coding style issues and added the driver to the build.)

Okay, I will resend them.

> Also, can you add a TODO file to the driver directory stating what is
> needed to be done, and who to contact about it?

I will test the device over the coming week and add in a TODO after that.

Thanks,
Manu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 |  Next  |  Last
Pages: 1 2 3
Prev: drivers/net/smc911x.c: use %pM to shown MAC address
Next: [PATCH] mm: move sys_mmap_pgoff from util.c