Prev: [patch v2.8 0/4] IPVS full NAT support + netfilter 'ipvs' match support
Next: [PATCH] serial: add support for OX16PCI958 card
From: Jiri Slaby on 22 Jul 2010 04:10 On 07/22/2010 09:37 AM, Neil Brown wrote: > I suspect that problem is that "do_sync" and "do_barriers" in > drivers/md/raid1.c are still 'bool' and should now be 'unsigned long'. > > I'm not sure how wide '_Bool' is, but I'm guess it isn't wide enough. ANSI says: An object declared as type _Bool is large enough to store the values 0 and 1. gcc spec doesn't say anything, but: $ gcc -S -x c -o - - unsigned long x = sizeof(_Bool); ^D .... x: .quad 1 I.e. sizeof(_Bool) = 1 byte. > Could you please try changing ever 'bool' in that file to 'unsigned long' > and see if that fixes it? Will do that. thanks, -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Hellwig on 22 Jul 2010 04:40 On Thu, Jul 22, 2010 at 05:37:16PM +1000, Neil Brown wrote: > I suspect that problem is that "do_sync" and "do_barriers" in > drivers/md/raid1.c are still 'bool' and should now be 'unsigned long'. > > I'm not sure how wide '_Bool' is, but I'm guess it isn't wide enough. > > Could you please try changing ever 'bool' in that file to 'unsigned long' > and see if that fixes it? Yes, that fixes it. We even had someone sending that fix a while ago, but it seems it's not applied to Jens' tree yet and I can't find it anymore either right now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Slaby on 22 Jul 2010 04:50
On 07/22/2010 10:36 AM, Christoph Hellwig wrote: > On Thu, Jul 22, 2010 at 05:37:16PM +1000, Neil Brown wrote: >> I suspect that problem is that "do_sync" and "do_barriers" in >> drivers/md/raid1.c are still 'bool' and should now be 'unsigned long'. >> >> I'm not sure how wide '_Bool' is, but I'm guess it isn't wide enough. >> >> Could you please try changing ever 'bool' in that file to 'unsigned long' >> and see if that fixes it? > > Yes, that fixes it. For me too. -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |