Prev: [HACKERS] Writeable CTEs and empty relations
Next: Knngist for 8.5
From: Fujii Masao on 7 Feb 2010 20:01
On Sun, Feb 7, 2010 at 1:02 AM, Bruce Momjian <bruce(a)momjian.us> wrote:
>> src/backend/access/transam/xlog.c
>> > else
>> > {
>> >     XLogRecPtr      InvalidXLogRecPtr = {0, 0};
>> >     ControlFile->minRecoveryPoint = InvalidXLogRecPtr;
>> > }
>>
>> In my original patch, the above is for the problem discussed in
>> http://archives.postgresql.org/pgsql-hackers/2009-12/msg02039.php
>>
>> Since you've already fixed the problem, that code is useless.
>> How about getting rid of that code?
>
> Has this been addressed?

No. We need to obtain the comment about that from Heikki.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Fujii Masao on 8 Feb 2010 04:42
On Mon, Feb 8, 2010 at 6:11 PM, Heikki Linnakangas
<heikki.linnakangas(a)enterprisedb.com> wrote:
> I removed that.

Thanks!

> It only makes a difference if you stop archive recovery, remove
> recovery.conf, and start up again, causing the server to do normal crash
> recovery. That's a "don't do that" scenario, but it seems better to not
> clear minRecoveryPoint, even though we don't check it during crash
> recovery. It might be useful debug information, and also if you then put
> recovery.conf back, we will enforce that you reach the minRecoveryPoint
> again.

This makes sense.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

 | 
Pages: 1
Prev: [HACKERS] Writeable CTEs and empty relations
Next: Knngist for 8.5