Bad watchdog ioctl definitions
in [Kernel]
|
Prev: [PATCH] documentation: slightly more correct value for MAP_HUGETLB in map_hugetlb.c
Next: [PATCH] watchdog docs: Fix use of WDIOC_SETOPTIONS ioctl.
From: James Hogan on 5 Apr 2010 05:40 Hi, I've noticed that some of the ioctl definitions in include/linux/watchdog.h are incorrect, for example: #define WDIOC_SETOPTIONS _IOR(WATCHDOG_IOCTL_BASE, 4, int) This is a write ioctl so should be _IOW #define WDIOC_KEEPALIVE _IOR(WATCHDOG_IOCTL_BASE, 5, int) I think this should just be _IO since the argument is ignored anyway From a quick grep, mpcore_wdt appears to be the only watchdog driver in drivers/watchdog that uses _IOC_DIR on the ioctl number, which breaks the SETOPTIONS ioctl on this driver. Is it usually even possible to change ioctl numbers for compatibility? What's the usual process? Cheers -- James Hogan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Cox on 5 Apr 2010 07:50
> Is it usually even possible to change ioctl numbers for compatibility? > What's the usual process? In this case I think its historical and we are stuck with it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |