Prev: Silent distfiles conflict between graphics/xface.el andmail/x-face-e21.
Next: Old ports bugs analyzis
From: Christian Weisgerber on 29 Mar 2010 15:53
There is a silly bug in RELENG_7 up to and including RELENG_7_3:
fdopendir(3) is available in libc, but the prototype is missing
from <dirent.h>.

This can have unexpected consequences. A configure script can
notice that fdopendir() is available, but due to the missing
prototype, the function will be typed as the default

int fdopendir();

This is bad. fdopendir() returns a pointer and unless correctly
prototyped, the return value will be truncated from 64 to 32 bits
on LP64 platforms.

So if you notice that something picks up the fdopendir() function
you need to either disable it for 702102 to 703100 (inclusive) or
make sure that the correct prototype

DIR *fdopendir(int);

is wedged in somehow.

This isn't a hypothetical concern. When I initially tried gtar
1.23 on 7.3/amd64, it left a trail of coredumps because of this.

--
Christian "naddy" Weisgerber naddy(a)mips.inka.de

_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Garrett Cooper on 29 Mar 2010 20:45
On Mon, Mar 29, 2010 at 12:53 PM, Christian Weisgerber
<naddy(a)mips.inka.de> wrote:
> There is a silly bug in RELENG_7 up to and including RELENG_7_3:
> fdopendir(3) is available in libc, but the prototype is missing
> from <dirent.h>.
>
> This can have unexpected consequences.  A configure script can
> notice that fdopendir() is available, but due to the missing
> prototype, the function will be typed as the default
>
>  int fdopendir();
>
> This is bad.  fdopendir() returns a pointer and unless correctly
> prototyped, the return value will be truncated from 64 to 32 bits
> on LP64 platforms.
>
> So if you notice that something picks up the fdopendir() function
> you need to either disable it for 702102 to 703100 (inclusive) or
> make sure that the correct prototype
>
>  DIR *fdopendir(int);
>
> is wedged in somehow.
>
> This isn't a hypothetical concern.  When I initially tried gtar
> 1.23 on 7.3/amd64, it left a trail of coredumps because of this.

Is there a bug outstanding for this?
Thanks,
-Garrett
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Xin LI on 29 Mar 2010 21:07
On Mon, Mar 29, 2010 at 5:45 PM, Garrett Cooper <yanefbsd(a)gmail.com> wrote:
[...]
>> This isn't a hypothetical concern.  When I initially tried gtar
>> 1.23 on 7.3/amd64, it left a trail of coredumps because of this.
>
>    Is there a bug outstanding for this?

This has been fixed in RELENG_7 before 7.3-RELEASE but re@ considered
it too late so the change didn't make it into the final release. No,
there is no outstanding bug report as I am aware.

Cheers,
--
Xin LI <delphij(a)delphij.net> http://www.delphij.net
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Garrett Cooper on 29 Mar 2010 22:42
On Mon, Mar 29, 2010 at 6:07 PM, Xin LI <delphij(a)gmail.com> wrote:
> On Mon, Mar 29, 2010 at 5:45 PM, Garrett Cooper <yanefbsd(a)gmail.com> wrote:
> [...]
>>> This isn't a hypothetical concern.  When I initially tried gtar
>>> 1.23 on 7.3/amd64, it left a trail of coredumps because of this.
>>
>>    Is there a bug outstanding for this?
>
> This has been fixed in RELENG_7 before 7.3-RELEASE but re@ considered
> it too late so the change didn't make it into the final release.  No,
> there is no outstanding bug report as I am aware.

Hmm... is it possible to release note it after the fact (or at
least release note all major / outstanding items discovered shortly
after the release, like the accidental zfs bootloader breakage)?
Thanks,
-Garrett
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Xin LI on 29 Mar 2010 23:18
Perhaps as an errata?

On Mar 29, 2010 7:42 PM, "Garrett Cooper" <yanefbsd(a)gmail.com> wrote:

On Mon, Mar 29, 2010 at 6:07 PM, Xin LI <delphij(a)gmail.com> wrote:
> On Mon, Mar 29, 2010 at 5:45 PM...
Hmm... is it possible to release note it after the fact (or at
least release note all major / outstanding items discovered shortly
after the release, like the accidental zfs bootloader breakage)?
Thanks,
-Garrett
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

 |  Next  |  Last
Pages: 1 2
Prev: Silent distfiles conflict between graphics/xface.el andmail/x-face-e21.
Next: Old ports bugs analyzis