Prev: perf_event: when events are grouped, the time enabled / running values are incorrect
Next: [GIT PULL] tracing: Lowering the footprint of TRACE_EVENTs
From: Masami Hiramatsu on 11 May 2010 16:10
Hi Mathieu,

Mathieu Desnoyers wrote:
> * Masami Hiramatsu (mhiramat(a)redhat.com) wrote:
>> Remove text_mutex locking in optimize_all_kprobes, because
>> that function doesn't modify text but just order optimization
>> to worker.
>
> Hi Masami,
>
> A few comments:
>
> 1) optimize_all_kprobes/unoptimize_all_kprobes should have comments saying that
> they are always called with kprobe_mutex held.
>
> 2) The sentence above in the changelog could be changed into:
>
> ..."because this function doesn't modify text. It simply queues optimizations
> for the kprobe_optimizer worker thread."
>
> 3)
>
> static DEFINE_MUTEX(kprobe_mutex); /* Protects kprobe_table */
>
> .. should also state that it protects optimizing_list.
>

Thanks! all comments are good to me!

Thank you again,




--
Masami Hiramatsu
e-mail: mhiramat(a)redhat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: perf_event: when events are grouped, the time enabled / running values are incorrect
Next: [GIT PULL] tracing: Lowering the footprint of TRACE_EVENTs