Prev: hot update doesn't work?
Next: [HACKERS] primary/secondary/master/slave/standby
From: Tom Lane on 12 May 2010 11:52
momjian(a)postgresql.org (Bruce Momjian) writes:
> Add PGAPPICON to all executable makefiles.

Is it really a good idea to have done that to the server, in particular?
I can't imagine it being a good idea to launch the postmaster from a
GUI, which is what I suppose this is good for.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tom Lane on 12 May 2010 13:44
Bruce Momjian <bruce(a)momjian.us> writes:
> Tom Lane wrote:
>> momjian(a)postgresql.org (Bruce Momjian) writes:
>>> Add PGAPPICON to all executable makefiles.
>>
>> Is it really a good idea to have done that to the server, in particular?
>> I can't imagine it being a good idea to launch the postmaster from a
>> GUI, which is what I suppose this is good for.

> Well, I assume this was the "icon", which I assumed should match for all
> the binaries, as compared to config files, for example.

Er... why are you committing undiscussed patches if you just "assume"
they will work, or indeed do anything useful at all? You should not
have touched this if you don't know exactly what it will do and why
changing it is a good thing.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tom Lane on 12 May 2010 15:59
Bruce Momjian <bruce(a)momjian.us> writes:
> All other binaries had such a designation, and all /contrib binaries
> were missing them. I assume I was doing cleanup. You want the icon
> removed from the backend makefile?

Yes. I'm prepared to believe that not having the icons set on the
contrib executables was an oversight. I'm much less prepared to assume
that not marking the postgres executable was an oversight. Again,
unless you *know* that this change is needed and appropriate, now is
not the time to be making it, and especially not without discussion.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

 | 
Pages: 1
Prev: hot update doesn't work?
Next: [HACKERS] primary/secondary/master/slave/standby