CVS corruption/mistagging?
in [PgSql]
|
Prev: Bug: Buffer cache is not scan resistant
Next: CREATE DATABASE cannot be executed from a function or multi-command string
From: Tom Lane on 14 Aug 2007 22:59 "Marc G. Fournier" <scrappy(a)hub.org> writes: > On Tuesday, August 14, 2007 22:20:16 -0400 Tom Lane <tgl(a)sss.pgh.pa.us> > wrote: >> Meanwhile, is there anyone around who can either (1) tar up the >> repository directory tree as root, or (2) confirm that a tarball >> made by a non-root committer is sufficient? > I've just finished tar'ng up the cvs repository as root ... Great --- launching cvs rtag command now. > I believe one as a > non-root would be sufficient also, since it *should* retain file ownership / > permissions with the -p option ... That's what I thought too, but a little extra paranoia doesn't hurt. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
From: Tom Lane on 14 Aug 2007 23:26 I wrote: > Great --- launching cvs rtag command now. Done, and I got a plausible-looking mix of messages like cvs rtag: Not removing branch tag `REL7_4_STABLE' from `/cvsroot/pgsql/src/tutorial/funcs_new.c,v'. and a fresh checkout of REL7_4_STABLE now matches what I had locally. So I think we walked away from that one. TODO items: * restrict, or at least log, cvs tag/rtag commands. Maybe report them to pgsql-committers. * I notice that the repository contains some files owned by no-longer-existent accounts, eg 258 in contrib/btree_gist: > ls -la total 460 drwxrwxr-x 6 scrappy dev 1024 Aug 15 03:00 . drwxrwxr-x 90 scrappy dev 2048 Aug 15 03:00 .. drwxrwxr-x 2 scrappy dev 512 Apr 20 15:16 Attic -r--r--r-- 1 tgl dev 9555 Jun 26 22:05 Makefile,v -r--r--r-- 1 258 dev 5870 Apr 20 16:19 README.btree_gist,v -r--r--r-- 1 tgl dev 12033 Aug 15 03:00 btree_bit.c,v -r--r--r-- 1 tgl dev 9902 Aug 15 03:00 btree_bytea.c,v -r--r--r-- 1 tgl dev 10227 Aug 15 03:00 btree_cash.c,v -r--r--r-- 1 tgl dev 11414 Aug 15 03:00 btree_date.c,v -r--r--r-- 1 tgl dev 10211 Aug 15 03:00 btree_float4.c,v -r--r--r-- 1 tgl dev 10074 Aug 15 03:00 btree_float8.c,v -r--r--r-- 1 tgl dev 33915 Aug 15 03:00 btree_gist.c,v -r--r--r-- 1 258 dev 4325 Apr 20 15:16 btree_gist.h,v -r--r--r-- 1 258 dev 58744 Apr 20 16:19 btree_gist.sql.in,v -r--r--r-- 1 tgl dev 14717 Aug 15 03:00 btree_inet.c,v -r--r--r-- 1 tgl dev 10234 Aug 15 03:00 btree_int2.c,v -r--r--r-- 1 tgl dev 10221 Aug 15 03:00 btree_int4.c,v -r--r--r-- 1 tgl dev 10235 Aug 15 03:00 btree_int8.c,v I suppose this is due to Magnus' cleanup of unused committers accounts. That was a good thing, but for security's sake these files ought to be chown'd to some existing committer's account. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster
From: "Marc G. Fournier" on 14 Aug 2007 23:50 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 - --On Tuesday, August 14, 2007 23:26:03 -0400 Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > I wrote: >> Great --- launching cvs rtag command now. > > Done, and I got a plausible-looking mix of messages like > cvs rtag: Not removing branch tag `REL7_4_STABLE' from > `/cvsroot/pgsql/src/tutorial/funcs_new.c,v'. and a fresh checkout of > REL7_4_STABLE now matches what I had locally. So I think we walked away from > that one. > > TODO items: > > * restrict, or at least log, cvs tag/rtag commands. Maybe report them > to pgsql-committers. working on it ... have code for it, I've just spent so much time with CVSROOT = /cvsroot, I have to relearn remote CVS :) >> ls -la > total 460 > drwxrwxr-x 6 scrappy dev 1024 Aug 15 03:00 . > drwxrwxr-x 90 scrappy dev 2048 Aug 15 03:00 .. > drwxrwxr-x 2 scrappy dev 512 Apr 20 15:16 Attic > -r--r--r-- 1 tgl dev 9555 Jun 26 22:05 Makefile,v > -r--r--r-- 1 258 dev 5870 Apr 20 16:19 README.btree_gist,v > -r--r--r-- 1 tgl dev 12033 Aug 15 03:00 btree_bit.c,v > -r--r--r-- 1 tgl dev 9902 Aug 15 03:00 btree_bytea.c,v > -r--r--r-- 1 tgl dev 10227 Aug 15 03:00 btree_cash.c,v > -r--r--r-- 1 tgl dev 11414 Aug 15 03:00 btree_date.c,v > -r--r--r-- 1 tgl dev 10211 Aug 15 03:00 btree_float4.c,v > -r--r--r-- 1 tgl dev 10074 Aug 15 03:00 btree_float8.c,v > -r--r--r-- 1 tgl dev 33915 Aug 15 03:00 btree_gist.c,v > -r--r--r-- 1 258 dev 4325 Apr 20 15:16 btree_gist.h,v > -r--r--r-- 1 258 dev 58744 Apr 20 16:19 btree_gist.sql.in,v > -r--r--r-- 1 tgl dev 14717 Aug 15 03:00 btree_inet.c,v > -r--r--r-- 1 tgl dev 10234 Aug 15 03:00 btree_int2.c,v > -r--r--r-- 1 tgl dev 10221 Aug 15 03:00 btree_int4.c,v > -r--r--r-- 1 tgl dev 10235 Aug 15 03:00 btree_int8.c,v > > I suppose this is due to Magnus' cleanup of unused committers accounts. > That was a good thing, but for security's sake these files ought to be > chown'd to some existing committer's account. I can do a quick chown -R scrappy on the whole repository ... ok? - ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email . scrappy(a)hub.org MSN . scrappy(a)hub.org Yahoo . yscrappy Skype: hub.org ICQ . 7615664 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGwnf34QvfyHIvDvMRAnGTAJ43gELVZ5Q5SpV/jppR9rODB/ILaACeKCEN DE16fnY/PmKlrvdHFaJeIKI= =VCFu -----END PGP SIGNATURE----- ---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster
From: "Marc G. Fournier" on 14 Aug 2007 23:59 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 - --On Tuesday, August 14, 2007 23:26:03 -0400 Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > * restrict, or at least log, cvs tag/rtag commands. Maybe report them > to pgsql-committers. It should be done ... if you try and create a tag, it should generate an error message ... not sure of the best way to test that it actually works, since, if it doesn't work, of course, you'll add on another tag, but do you want to try and create a 'fake tag' and then delete it afterwards? - ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email . scrappy(a)hub.org MSN . scrappy(a)hub.org Yahoo . yscrappy Skype: hub.org ICQ . 7615664 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGwnoO4QvfyHIvDvMRArHSAJ4qYuexUGn6Ff3/PkHU/DjJBlCQnwCgxyy9 Qc852wMVRRMYdwoD3+p7X3Y= =FCD9 -----END PGP SIGNATURE----- ---------------------------(end of broadcast)--------------------------- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
From: Tom Lane on 15 Aug 2007 00:08
"Marc G. Fournier" <scrappy(a)hub.org> writes: >> That was a good thing, but for security's sake these files ought to be >> chown'd to some existing committer's account. > I can do a quick chown -R scrappy on the whole repository ... ok? Seems close enough, but please keep that tarball around for awhile just in case we need to look at the prior state. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 4: Have you searched our list archives? http://archives.postgresql.org |