Prev: PM: Make it possible to avoid wakeup events from being lost
Next: Ext4: Make file creation time, i_version and i_generation available by xattrs
From: Andrew Morton on 28 Jun 2010 15:20
On Wed, 23 Jun 2010 08:07:34 +0900
Minchan Kim <minchan.kim(a)gmail.com> wrote:

> Acked-by: Johannes Weiner <hannes(a)cmpxchg.org>
> Reviewed-by: Minchan Kim <minchan.kim(a)gmail.com>
> Reviewed-by: Rik van Riel <riel(a)redhat.com>
> Reviewed-by: KOSAKI Motohiro<kosaki.motohiro(a)jp.fujitsu.com>

The patch is a bit sucky, isn't it?

a) the cond_resched() which Larry's patch adds is very special. It
_looks_ like a random preemption point but it's actually critical to
the correct functioning of the system. That's utterly unobvious to
anyone who reads the code, so a comment explaining this *must* be
included.

b) cond_resched() is a really crappy way of solving the problem
which Larry described. It will sit there chewing away CPU time
until kswapd's timeslice expires.

I suppose we can live with b) although it _does_ suck and I'd suggest
that the comment include a big FIXME, so someone might fix it.

Larry, please fix a), gather the acks and reviewed-by's, update the
changelog to identify the commit which broke it and resend?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: PM: Make it possible to avoid wakeup events from being lost
Next: Ext4: Make file creation time, i_version and i_generation available by xattrs