Change struct flchip_shared spinlock locking into mutex
in [Kernel]
|
Prev: cgroup : make the mount options parsing more accurate
Next: kexec: set prstatus.pr_pid to cpu id when current->pid is 0
From: Arnd Bergmann on 3 Aug 2010 04:30 On Monday 02 August 2010, stefani(a)seibold.net wrote: > From: Stefani Seibold <stefani(a)seibold.net> > > This patch prevent to schedule while atomic by changing the > flchip_shared spinlock into a mutex. This should be save since no atomic > path will use this lock. I don't know this code well, but the patch looks correct and seems to be needed. Acked-by: Arnd Bergmann <arnd(a)arndb.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Artem Bityutskiy on 5 Aug 2010 01:00 On Mon, 2010-08-02 at 21:40 +0200, stefani(a)seibold.net wrote: > From: Stefani Seibold <stefani(a)seibold.net> > > This patch prevent to schedule while atomic by changing the > flchip_shared spinlock into a mutex. This should be save since no atomic > path will use this lock. > > This patch is based on linux kernel 2.6.35. Please apply. > > It was requested by Arnd Bergmann and Vasiliy Kulikov. Taken to my l2-mtd-2.6.git / master -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Artem Bityutskiy on 5 Aug 2010 01:40 On Thu, 2010-08-05 at 07:58 +0300, Artem Bityutskiy wrote: > On Mon, 2010-08-02 at 21:40 +0200, stefani(a)seibold.net wrote: > > From: Stefani Seibold <stefani(a)seibold.net> > > > > This patch prevent to schedule while atomic by changing the > > flchip_shared spinlock into a mutex. This should be save since no atomic > > path will use this lock. > > > > This patch is based on linux kernel 2.6.35. Please apply. > > > > It was requested by Arnd Bergmann and Vasiliy Kulikov. > > Taken to my l2-mtd-2.6.git / master This patch causes the following compilation error: drivers/mtd/lpddr/lpddr_cmds.c: In function 'lpddr_cmdset': drivers/mtd/lpddr/lpddr_cmds.c:101: warning: passing argument 1 of 'spinlock_check' from incompatible pointer type include/linux/spinlock.h:271: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' drivers/mtd/lpddr/lpddr_cmds.c:101: error: 'struct mutex' has no member named 'rlock' drivers/mtd/lpddr/lpddr_cmds.c: In function 'get_chip': drivers/mtd/lpddr/lpddr_cmds.c:220: warning: passing argument 1 of 'spin_lock' from incompatible pointer type include/linux/spinlock.h:282: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' drivers/mtd/lpddr/lpddr_cmds.c:233: warning: passing argument 1 of 'spin_unlock' from incompatible pointer type include/linux/spinlock.h:322: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' drivers/mtd/lpddr/lpddr_cmds.c:248: warning: passing argument 1 of 'spin_lock' from incompatible pointer type include/linux/spinlock.h:282: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' drivers/mtd/lpddr/lpddr_cmds.c:264: warning: passing argument 1 of 'spin_unlock' from incompatible pointer type include/linux/spinlock.h:322: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' drivers/mtd/lpddr/lpddr_cmds.c:278: warning: passing argument 1 of 'spin_unlock' from incompatible pointer type include/linux/spinlock.h:322: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' drivers/mtd/lpddr/lpddr_cmds.c: In function 'put_chip': drivers/mtd/lpddr/lpddr_cmds.c:351: warning: passing argument 1 of 'spin_lock' from incompatible pointer type include/linux/spinlock.h:282: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' drivers/mtd/lpddr/lpddr_cmds.c:359: warning: passing argument 1 of 'spin_unlock' from incompatible pointer type include/linux/spinlock.h:322: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' drivers/mtd/lpddr/lpddr_cmds.c:377: warning: passing argument 1 of 'spin_unlock' from incompatible pointer type include/linux/spinlock.h:322: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' drivers/mtd/lpddr/lpddr_cmds.c:381: warning: passing argument 1 of 'spin_unlock' from incompatible pointer type include/linux/spinlock.h:322: note: expected 'struct spinlock_t *' but argument is of type 'struct mutex *' Removed from my tree. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Artem Bityutskiy on 5 Aug 2010 06:00
On Thu, 2010-08-05 at 09:19 +0200, stefani(a)seibold.net wrote: > From: Stefani Seibold <stefani(a)seibold.net> > > This patch prevent to schedule while atomic by changing the > flchip_shared spinlock into a mutex. This should be save since no atomic > path will use this lock. > > This patch is based on linux kernel 2.6.35. Please apply. > > It was suggested by Arnd Bergmann and Vasiliy Kulikov. Pushed to my l2-mtd-2.6.git / master. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |