Prev: Two small fixes for 2.6.34
Next: [PATCH 1/2] DMA ENGINE: Do not reset 'private' of channel
From: Nigel Cunningham on 7 May 2010 06:00
Hi.

On 07/05/10 19:50, Steven Liu wrote:
> Check kmalloc return value before use the bigrxbuf_virtual ,when
> bigrxbuf_virtual is NULL, kfree bigtxbuf_virtual

Ta :)

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Steven Liu on 7 May 2010 06:00
Check kmalloc return value before use the bigrxbuf_virtual ,when
bigrxbuf_virtual is NULL, kfree bigtxbuf_virtual

2010/5/7 Nigel Cunningham <nigel(a)tuxonice.net>:
> Hi.
>
> No commit comment?
>
> On 07/05/10 17:17, Steven Liu wrote:
>>
>> Signed-off-by: LiuQi<lingjiujianke(a)gmail.com>
>> ---
>> �arch/arm/mach-u300/dummyspichip.c | � �5 +++++
>> �1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-u300/dummyspichip.c
>> b/arch/arm/mach-u300/dummyspichip.c
>> index 5f55012..df19f9b 100644
>> --- a/arch/arm/mach-u300/dummyspichip.c
>> +++ b/arch/arm/mach-u300/dummyspichip.c
>> @@ -64,6 +64,11 @@ static ssize_t dummy_looptest(struct device *dev,
>> � � � � � � � �goto out;
>> � � � �}
>> � � � �bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
>> + � � � if (bigrxbuf_virtual == NULL) {
>> + � � � � � � � status = -ENOMEM;
>> + � � � � � � � kfree(bigtxbuf_virtual);
>
> Why kfree something you know is NULL?
>
> Regards,
>
> Nigel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Steven Liu on 7 May 2010 06:00
Hi, guy,

Thanks for your help, :)


Best Regards


LiuQi

2010/5/7 Nigel Cunningham <nigel(a)tuxonice.net>:
> Hi.
>
> On 07/05/10 19:50, Steven Liu wrote:
>>
>> Check kmalloc return value before use the bigrxbuf_virtual ,when
>> bigrxbuf_virtual is NULL, kfree �bigtxbuf_virtual
>
> Ta :)
>
> Nigel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Linus WALLEIJ on 7 May 2010 15:00
[Steven]

> the code in arch/arm/mach-u300/dummyspichip.c is
>
> bigtxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
> if (bigtxbuf_virtual == NULL) {
> status = -ENOMEM;
> goto out;
> }
> bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
>
>
> if kmalloc memory space for bigrxbuf_virtual is NULL, when it have
> kmalloc DMA_TEST_SIZE memory space for bigtxbuf_virtual,so ,if kmalloc
> memory for bigtxbuf_virtual success and kmalloc memory for
> bigrxbuf_virtual faild,i think we must kfree bigtxbuf_virtual memory

Ha, I also misread tx for rx, sorry.

Acked-by: Linus Walleij <linus.walleij(a)stericsson.com>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Nigel Cunningham on 7 May 2010 21:30
Hi again.

On 08/05/10 04:57, Linus WALLEIJ wrote:
> [Steven]
>
>> the code in arch/arm/mach-u300/dummyspichip.c is
>>
>> bigtxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
>> if (bigtxbuf_virtual == NULL) {
>> status = -ENOMEM;
>> goto out;
>> }
>> bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
>>
>>
>> if kmalloc memory space for bigrxbuf_virtual is NULL, when it have
>> kmalloc DMA_TEST_SIZE memory space for bigtxbuf_virtual,so ,if kmalloc
>> memory for bigtxbuf_virtual success and kmalloc memory for
>> bigrxbuf_virtual faild,i think we must kfree bigtxbuf_virtual memory
>
> Ha, I also misread tx for rx, sorry.

I've just looked again, and the original version did have rx in the
test. We weren't seeing things :)

> Acked-by: Linus Walleij<linus.walleij(a)stericsson.com>

Acked-by: Nigel Cunningham <nigel(a)tuxonice.net>

Regards,

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  |  Next  |  Last
Pages: 1 2 3
Prev: Two small fixes for 2.6.34
Next: [PATCH 1/2] DMA ENGINE: Do not reset 'private' of channel