Checkpatch: warn about unexpectedly long msleep's
in [Kernel]
|
Prev: ext4 performance regression 2.6.27-stable versus 2.6.32 and later
Next: Checkpatch: prefer usleep over udelay
From: Andrew Morton on 28 Jul 2010 16:30 On Wed, 28 Jul 2010 12:33:07 -0700 Patrick Pannuto <ppannuto(a)codeaurora.org> wrote: > As explained in Documentation/timers/delays.txt, msleep's > of < 20ms may sleep for as long as 20ms. Caller's of > msleep(1) or msleep(2), etc are likely not to expect this > quirky behavior - warn them. > > Signed-off-by: Patrick Pannuto <ppannuto(a)codeaurora.org> > --- > scripts/checkpatch.pl | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 892ae62..0ca2ea5 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2578,6 +2578,13 @@ sub process { > } > } > > +# warn about unexpectedly long msleep's > + if ($line =~ /\bmsleep\s*\((\d+)\);/) { > + if ($1 < 20) { > + WARN("msleep < 20ms can sleep for up to 20ms; see Documentation/timers/delays.txt\n" . $line); Should be timers-howto.txt? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Patrick Pannuto on 28 Jul 2010 16:50
>> +# warn about unexpectedly long msleep's >> + if ($line =~ /\bmsleep\s*\((\d+)\);/) { >> + if ($1 < 20) { >> + WARN("msleep < 20ms can sleep for up to 20ms; see Documentation/timers/delays.txt\n" . $line); > > Should be timers-howto.txt? > > Yes, will fix -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |