Prev: staging: mrst-touchscreen: fix leaks
Next: [PATCH] remove unnecesary while loop in ext2_xattr_get
From: Konrad Rzeszutek Wilk on 12 Jul 2010 11:10
On Thu, Jul 08, 2010 at 09:42:08AM -0700, Dan Magenheimer wrote:
> Signed-off-by: Dan Magenheimer <dan.magenheimer(a)oracle.com>

One nitpick:
...
> +
> +int tmem_enabled;
> +
> +static int __init enable_tmem(char *s)
> +{
> + tmem_enabled = 1;
> + return 1;
> +}
> +
> +__setup("tmem", enable_tmem);

Perhaps 'tmem_setup' is more appropiate as it might be that this
function in the future would be only used to disable tmem, not actually
enable it?

Otherwise, it has been reviewed by me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: staging: mrst-touchscreen: fix leaks
Next: [PATCH] remove unnecesary while loop in ext2_xattr_get