Clearing global statistics
in [PgSql]
|
From: Greg Smith on 17 Jan 2010 18:52 Magnus Hagander wrote: > Maybe this should be "Unrecognized reset target: %s", target, and also > a errhint() saying which targets are allowed. Thoughts? > That seems reasonable. The other thing I realized is that I forgot to add the new function to the right place in doc/src/sgml/func.sgml : <indexterm> <primary>pg_stat_reset_shared</primary> </indexterm> I can send an updated patch with both of these things fixed tomorrow. Given that we're talking 5 lines of change here, if it's easier for you to just patch a working copy you've already started on that's fine too. -- Greg Smith 2ndQuadrant Baltimore, MD PostgreSQL Training, Services and Support greg(a)2ndQuadrant.com www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 18 Jan 2010 05:02 On Mon, Jan 18, 2010 at 00:52, Greg Smith <greg(a)2ndquadrant.com> wrote: > Magnus Hagander wrote: >> >> Maybe this should be "Unrecognized reset target: %s", target, and also >> a errhint() saying which targets are allowed. Thoughts? >> > > That seems reasonable. The other thing I realized is that I forgot to add > the new function to the right place in doc/src/sgml/func.sgml : > > <indexterm> > <primary>pg_stat_reset_shared</primary> > </indexterm> > > I can send an updated patch with both of these things fixed tomorrow. Given > that we're talking 5 lines of change here, if it's easier for you to just > patch a working copy you've already started on that's fine too. I can deal with that, I just wanted to make sure we're in agreement. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 19 Jan 2010 09:12 On Mon, Jan 18, 2010 at 11:02, Magnus Hagander <magnus(a)hagander.net> wrote: > On Mon, Jan 18, 2010 at 00:52, Greg Smith <greg(a)2ndquadrant.com> wrote: >> Magnus Hagander wrote: >>> >>> Maybe this should be "Unrecognized reset target: %s", target, and also >>> a errhint() saying which targets are allowed. Thoughts? >>> >> >> That seems reasonable. The other thing I realized is that I forgot to add >> the new function to the right place in doc/src/sgml/func.sgml : >> >> <indexterm> >> <primary>pg_stat_reset_shared</primary> >> </indexterm> >> >> I can send an updated patch with both of these things fixed tomorrow. Given >> that we're talking 5 lines of change here, if it's easier for you to just >> patch a working copy you've already started on that's fine too. > > I can deal with that, I just wanted to make sure we're in agreement. Applied with agreed upon change and some minor styling/formatting changes. The mention you have about documentation above is incorrect - the other pg_stat_xyz functions aren't listed there, so neither should this one. At least from AFAICT ;) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
First
|
Prev
|
Pages: 1 2 3 4 Prev: Fix for memory leak in dblink Next: [HACKERS] Any ExecStoreTuple end runs? |