Crypto: geode-aes: Fix some code style issues
in [Kernel]
|
Prev: [PATCH 1/5] Add a global synchronization point for pvclock
Next: [PATCH 2/5] change msr numbers for kvmclock
From: Andres Salomon on 15 Apr 2010 14:40 On Thu, 15 Apr 2010 13:17:59 -0400 Chihau Chau <chihau(a)gmail.com> wrote: > From: Chihau Chau <chihau(a)gmail.com> > > This fixes some code style issues like: > > - Use #include <linux/io.h> instead of <asm/io.h> and #include > <linux/delay.h> instead of <asm/delay.h> > > - Use "foo *bar" instead of "foo * bar" > > - Add a space after the for or while sentence and before the open > parenthesis '(' > > - Don't use assignments in a if condition > > Signed-off-by: Chihau Chau <chihau(a)gmail.com> Looks obviously correct to me. Acked-by: Andres Salomon <dilinger(a)debian.org> > --- > drivers/crypto/geode-aes.c | 36 ++++++++++++++++++++---------------- > 1 files changed, 20 insertions(+), 16 deletions(-) > > diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/geode-aes.c > index c7a5a43..09389dd 100644 > --- a/drivers/crypto/geode-aes.c > +++ b/drivers/crypto/geode-aes.c > @@ -15,14 +15,14 @@ > #include <crypto/algapi.h> > #include <crypto/aes.h> > > -#include <asm/io.h> > -#include <asm/delay.h> > +#include <linux/io.h> > +#include <linux/delay.h> > I don't see any delay functions being used anywhere; delay.h can probably just be dropped. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Sebastian Andrzej Siewior on 16 Apr 2010 16:10 * Chihau Chau | 2010-04-15 13:17:59 [-0400]: >From: Chihau Chau <chihau(a)gmail.com> > >This fixes some code style issues like: looks good Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Herbert Xu on 19 Apr 2010 09:10
On Thu, Apr 15, 2010 at 05:17:59PM +0000, Chihau Chau wrote: > From: Chihau Chau <chihau(a)gmail.com> > > This fixes some code style issues like: Applied. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert(a)gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |