Prev: [PATCH] HyperV: fix up the license to mshyperv.c
Next: [BUG] perf_event: when events are grouped, the time enabled / running values are incorrect
From: Dan Williams on 7 May 2010 20:20
On Tue, May 4, 2010 at 2:22 AM, Jassi Brar <jassi.brar(a)samsung.com> wrote:
> The member 'private' of 'struct dma_chan' is meant for passing
> data between client and the controller driver.
>
> The DMA client driver may point it to platform specific stuff after
> acquiring the channel. So, it is the responsiblity of the same code
> to reset it, if it must.
>
> The DMA engine doesn't set it and hence, shouldn't reset it either.
>
> Signed-off-by: Jassi Brar <jassi.brar(a)samsung.com>
>
> This reseting of private by DMA Engine comes in the way of implementing
> default channel settings during DMAC probe. That capability is useful
> for not having the clients to always provide platform specific data,
> like Rx/Tx FIFO addresses, which usually doesn't change across channel
> requests.
>

Ok I like this explanation better than the changelog you have above
because it clarifies that the driver is setting a default that the
client can override at registration time, but when this is happening
dmaengine should get out of the way.

Applied.

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] HyperV: fix up the license to mshyperv.c
Next: [BUG] perf_event: when events are grouped, the time enabled / running values are incorrect