Documentation/timers/hpet_example.c compile bug
in [Kernel]
|
From: Heiko Carstens on 28 May 2010 07:40 Hi Randy, since your commit e61863099f58e458f08c101da87da752a1e009f5 "Documentation/timers/: split txt and source files" I get this compile error on s390 with an allyesconfig: In file included from Documentation/timers/hpet_example.c:15: /usr/include/linux/hpet.h:11: error: expected specifier-qualifier-list before 'u64' Please fix. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 29 May 2010 14:50 On 05/28/10 04:35, Heiko Carstens wrote: > Hi Randy, > > since your commit e61863099f58e458f08c101da87da752a1e009f5 > "Documentation/timers/: split txt and source files" I get this compile > error on s390 with an allyesconfig: > > In file included from Documentation/timers/hpet_example.c:15: > /usr/include/linux/hpet.h:11: error: expected specifier-qualifier-list before 'u64' Where is the u64? My (x86_64) copy of /usr/include/linux/hpet.h looks like: 1 #ifndef __HPET__ 2 #define __HPET__ 1 3 4 5 6 7 struct hpet_info { 8 unsigned long hi_ireqfreq; /* Hz */ 9 unsigned long hi_flags; /* information */ 10 unsigned short hi_hpet; 11 unsigned short hi_timer; 12 }; 13 14 #define HPET_INFO_PERIODIC 0x0010 /* periodic-capable comparator */ 15 16 #define HPET_IE_ON _IO('h', 0x01) /* interrupt on */ 17 #define HPET_IE_OFF _IO('h', 0x02) /* interrupt off */ 18 #define HPET_INFO _IOR('h', 0x03, struct hpet_info) 19 #define HPET_EPI _IO('h', 0x04) /* enable periodic */ 20 #define HPET_DPI _IO('h', 0x05) /* disable periodic */ 21 #define HPET_IRQFREQ _IOW('h', 0x6, unsigned long) /* IRQFREQ usec */ 22 23 #endif /* !__HPET__ */ I guess s390 hpet.h looks different? Does it just need to #include <linux/types.h> ? Or is the problem the kernel-space u64 vs. userspace __u64? > Please fix. Any suggestions? -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 30 May 2010 22:40 On 05/29/10 11:41, Randy Dunlap wrote: > On 05/28/10 04:35, Heiko Carstens wrote: >> Hi Randy, >> >> since your commit e61863099f58e458f08c101da87da752a1e009f5 >> "Documentation/timers/: split txt and source files" I get this compile >> error on s390 with an allyesconfig: >> >> In file included from Documentation/timers/hpet_example.c:15: >> /usr/include/linux/hpet.h:11: error: expected specifier-qualifier-list before 'u64' > > Where is the u64? My (x86_64) copy of /usr/include/linux/hpet.h looks like: > > 1 #ifndef __HPET__ > 2 #define __HPET__ 1 > 3 > 4 > 5 > 6 > 7 struct hpet_info { > 8 unsigned long hi_ireqfreq; /* Hz */ > 9 unsigned long hi_flags; /* information */ > 10 unsigned short hi_hpet; > 11 unsigned short hi_timer; > 12 }; > 13 > 14 #define HPET_INFO_PERIODIC 0x0010 /* periodic-capable comparator */ > 15 > 16 #define HPET_IE_ON _IO('h', 0x01) /* interrupt on */ > 17 #define HPET_IE_OFF _IO('h', 0x02) /* interrupt off */ > 18 #define HPET_INFO _IOR('h', 0x03, struct hpet_info) > 19 #define HPET_EPI _IO('h', 0x04) /* enable periodic */ > 20 #define HPET_DPI _IO('h', 0x05) /* disable periodic */ > 21 #define HPET_IRQFREQ _IOW('h', 0x6, unsigned long) /* IRQFREQ usec */ > 22 > 23 #endif /* !__HPET__ */ > > I guess s390 hpet.h looks different? Does it just need to #include <linux/types.h> ? > Or is the problem the kernel-space u64 vs. userspace __u64? > >> Please fix. > > Any suggestions? Does it even make sense to build hpet_example on s390? I.e., does s390 have hpet? If not, then a simple Kconfig "depends on X86" or "depends on !S390" will fix this. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arjan van de Ven on 30 May 2010 22:50 On Sun, 30 May 2010 19:34:35 -0700 Randy Dunlap <randy.dunlap(a)oracle.com> wrote: > > Does it even make sense to build hpet_example on s390? > I.e., does s390 have hpet? > If not, then a simple Kconfig "depends on X86" or "depends on !S390" > will fix this. HPET is very PC specific. but.. even on x86, it does not really make sense, and exposing this as an interface to userspace is a historical mistake, the use of which we really ought to discourage. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 30 May 2010 23:00
On 05/30/10 19:49, Arjan van de Ven wrote: > On Sun, 30 May 2010 19:34:35 -0700 > Randy Dunlap <randy.dunlap(a)oracle.com> wrote: >> >> Does it even make sense to build hpet_example on s390? >> I.e., does s390 have hpet? >> If not, then a simple Kconfig "depends on X86" or "depends on !S390" >> will fix this. > > HPET is very PC specific. > > but.. even on x86, it does not really make sense, and exposing this as > an interface to userspace is a historical mistake, the use of which we > really ought to discourage. Do you mean exposing anything that is in /usr/include/linux/hpet.h via ioctls? especially struct hpet_info ? -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |