Exclude DAHDI devices from being probed by netjet
in [Kernel]
|
Prev: [PATCH 1/2] drivers/scsi: Use GFP_ATOMIC when a lock is held
Next: x86 platform driver updates for 2.6.35
From: Alan Cox on 30 May 2010 10:10 > 2. I don't have more precise data than the PCI ID tables in the drivers. > Does this run the risk of excluding some actual Netjet ISDN cards? Is there a reason you are seeing so many different vendor values - surely you should see a single 'Digium' subvendor, and various subdevice values ? > + switch (pdev->subsystem_vendor) { > + /* Fall-through */ > + case 0x2151: /* Yeastart YSTDM8xx (ystdm8xx) */ > + case 0xe16b: /* Zapata Project PCI-Radio (pciradio) */ > + case 0x6159: /* Digium Wildcard T100/E100 (wct1xxp) */ > + case 0x71fe: /* Digium Wildcard TE110P (wcte1xp) */ > + case 0x795e: /* Digium Wildcard TE110P (wcte1xp) */ > + case 0x797e: /* Digium Wildcard TE110P (wcte1xp) */ > + case 0x79de: /* Digium Wildcard TE110P (wcte1xp) */ > + case 0x79df: /* Digium Wildcard TE110P (wcte1xp) */ > + case 0x8084: /* Digium Wildcard X101P clone (wcfxo) */ > + case 0x8085: /* Digium Wildcard X101P (wcfxo) */ > + case 0x8086: /* Digium Wildcard X101P clone (wcfxo) */ > + case 0x8087: /* Digium Wildcard X101P clone (wcfxo) */ > + case 0xa800: /* Digium Wildcard TDM400P Rev H (wctdm) */ > + case 0xa801: /* Digium Wildcard TDM400P Rev H (wctdm) */ > + case 0xa8fd: /* Digium Wildcard TDM400P Rev H (wctdm) */ > + case 0xa901: /* Digium Wildcard TDM400P Rev H (wctdm) */ > + case 0xa908: /* Digium Wildcard TDM400P Rev H (wctdm) */ > + case 0xa9fd: /* Digium Wildcard TDM400P Rev H (wctdm) */ > + case 0xb100: /* Digium Wildcard TDM400P Rev E/F (wctdm) */ > + case 0xb118: /* Digium Wildcard TDM400P Rev I (wctdm) */ > + case 0xb119: /* Digium Wildcard TDM400P Rev I (wctdm) */ > + case 0xb1d9: /* Digium Wildcard TDM400P Rev I (wctdm) */ > + case 0xa159: /* Digium Wildcard S400P Prototype (wctdm) */ > + case 0xe159: /* Digium Wildcard S400P Prototype (wctdm) */ That might be better as a table. You can then als include the name and match details in the report which will help diagnose problems with it eg struct whatever { u16 svid, sdid; const char *name; } And then print netjet: %s card is not supported by this driver (%04X, %04X).\n", name, svid, sdid Then again we don't seem to have a driver for these other kernel devices so perhaps the safe default would be to warn and continue unless a module option is set. At least initially. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |