Prev: [git pull] more PCMCIA updates for 2.6.34 (including ioctl deprecation)
Next: more PCMCIA updates for 2.6.34 (including ioctl deprecation)
From: Dan Carpenter on 3 Mar 2010 03:40
On Wed, Mar 03, 2010 at 11:00:53AM +1100, imunsie(a)au1.ibm.com wrote:
> From: Ian Munsie <imunsie(a)au.ibm.com>
>
> The compiler throws the following warning during compilation:
>
> drivers/isdn/hardware/mISDN/hfcpci.c:2319: warning: ignoring return value of 'driver_for_each_device', declared with attribute warn_unused_result
>
> driver_for_each_device is being used to call _hfcpci_softirq for each
> device, which will only ever return 0.
> This patch explicitly ignores the return value to silence the warning.
>
> Signed-off-by: Ian Munsie <imunsie(a)au.ibm.com>
> ---
> drivers/isdn/hardware/mISDN/hfcpci.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
> index 70e6b0e..1333d4a 100644
> --- a/drivers/isdn/hardware/mISDN/hfcpci.c
> +++ b/drivers/isdn/hardware/mISDN/hfcpci.c
> @@ -2316,7 +2316,8 @@ _hfcpci_softirq(struct device *dev, void *arg)
> static void
> hfcpci_softirq(void *arg)
> {
> - (void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
> + int err;
> + err = driver_for_each_device(&hfc_driver.driver, NULL, arg,
> _hfcpci_softirq);
>

Could you name the variable "dummy" instead of "err"? Every few months I go through
and look for code like what you have done here and it sucks to try figure out if
people are ignoring the errors on purpose or not.

regards,
dan carpenter

> /* if next event would be in the past ... */
> --
> 1.6.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [git pull] more PCMCIA updates for 2.6.34 (including ioctl deprecation)
Next: more PCMCIA updates for 2.6.34 (including ioctl deprecation)