Expose the statistics in blkio.time and blkio.sectors for the root cgroup
in [Kernel]
|
Prev: [PATCH] x86: let 'reservetop' functioning right
Next: [PATCH 2/2] tracing: Fix lockdep warning in global_clock()
From: Vivek Goyal on 24 Mar 2010 21:00 On Wed, Mar 24, 2010 at 04:35:56PM -0700, Ricky Benitez wrote: > Currently, the io statistics for the root cgroup are maintained, but > they are not shown because the device information is not available at > the point that the root blkio cgroup is created. This patch updates > the device information when the statistics are updated so that the > statistics become visible. > Ok, root group is created when request queue is being initialized and device information like major/minor number is not available. This is not the cleanest solution but can't think of something better right now. Acked-by: Vivek Goyal <vgoyal(a)redhat.com> Thanks Vivek > Signed-off-by: Ricky Benitez <rickyb(a)google.com> > --- > block/cfq-iosched.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c > index dee9d93..4a3579a 100644 > --- a/block/cfq-iosched.c > +++ b/block/cfq-iosched.c > @@ -947,6 +947,11 @@ cfq_find_alloc_cfqg(struct cfq_data *cfqd, struct cgroup *cgroup, int create) > unsigned int major, minor; > > cfqg = cfqg_of_blkg(blkiocg_lookup_group(blkcg, key)); > + if (cfqg && !cfqg->blkg.dev && bdi->dev && dev_name(bdi->dev)) { > + sscanf(dev_name(bdi->dev), "%u:%u", &major, &minor); > + cfqg->blkg.dev = MKDEV(major, minor); > + goto done; > + } > if (cfqg || !create) > goto done; > > -- > 1.7.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |