Prev: mtd: Change positive error return into negative in mtd_do_writeoob()
Next: coredump: set ->group_exit_code for other CLONE_VM tasks too
From: Roel Kluin on 8 Feb 2010 11:10 In arch/frv/kernel/traps.c, show_backtrace(), if sp is 0 then the dump does not succeed because stop was set to 0 and unaltered when we reach the unsigned comparison: while (tos < stop) {...} The naming stop may on the other hand suggest that this is desired, is it? Roel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: roel kluin on 8 Feb 2010 13:50
On Mon, Feb 8, 2010 at 5:08 PM, Roel Kluin <roel.kluin(a)gmail.com> wrote: > In arch/frv/kernel/traps.c, show_backtrace(), if sp is 0 > then the dump does not succeed because stop was set to 0 > and unaltered when we reach the unsigned comparison: > > while (tos < stop) {...} I was mistaken, a while (tos >= stop) won't end Roel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |