Prev: [PATCH 5/4] Provide __dma_aligned macro
Next: x86 rwsem: down_read_critical implementation
From: Stefano Stabellini on 19 May 2010 10:30
On Tue, 18 May 2010, Jeremy Fitzhardinge wrote:
> On 05/18/2010 03:23 AM, Stefano Stabellini wrote:
> > Make sure chip_data is not NULL before accessing it.
> >
>
> You should clarify under what circumstances it can be legitimately NULL.
>
>

The VIRQ_TIMER handler and virq handlers in general don't have any
chip_data.


> > Signed-off-by: Stefano Stabellini <stefano.stabellini(a)eu.citrix.com>
> > ---
> > arch/x86/kernel/apic/io_apic.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> > index eb2789c..c64499c 100644
> > --- a/arch/x86/kernel/apic/io_apic.c
> > +++ b/arch/x86/kernel/apic/io_apic.c
> > @@ -1732,6 +1732,8 @@ __apicdebuginit(void) print_IO_APIC(void)
> > struct irq_pin_list *entry;
> >
> > cfg = desc->chip_data;
> > + if (!cfg)
> > + continue;
> > entry = cfg->irq_2_pin;
> > if (!entry)
> > continue;
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 5/4] Provide __dma_aligned macro
Next: x86 rwsem: down_read_critical implementation