Prev: block: Per-partition block IO performance histograms
Next: [PATCH 0/1] BH1770GLC / SFH7770 combined ambient light / proximity sensor
From: Christoph Hellwig on 15 Apr 2010 06:50
On Thu, Apr 15, 2010 at 02:40:39PM +1000, Anton Blanchard wrote:
> int blkdev_fsync(struct file *filp, struct dentry *dentry, int datasync)
> {
> - struct block_device *bdev = I_BDEV(filp->f_mapping->host);
> + struct inode *bd_inode = filp->f_mapping->host;
> + struct block_device *bdev = I_BDEV(bd_inode);
> int error;
>
> + mutex_unlock(&bd_inode->i_mutex);
> +
> error = sync_blockdev(bdev);

Actually you can just drop this call entirely. sync_blockdev is an
overcomplicated alias for filemap_write_and_wait on the block device
inode, which is exactl what we did just before calling into ->fsync

It might be worth to still drop i_mutex for the cache flush, though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: block: Per-partition block IO performance histograms
Next: [PATCH 0/1] BH1770GLC / SFH7770 combined ambient light / proximity sensor