Prev: cfq-iosched: don't allow aliased requests to starve others
Next: [PATCH] CEPH: Correct obvious typo of Kconfig variable "CRYPTO_AES"
From: Rabin Vincent on 24 Jul 2010 06:40
On Thu, Jul 22, 2010 at 03:57:30PM -0700, Jeff Ohlstein wrote:
> Unless gic_ack_irq is called from __do_IRQ, interrupt should not
> be disabled in the ack function. Disabling the interrupt causes
> handle_edge_irq to never enable it again.

The GIC doesn't use handle_edge_irq.

Anyway, this change is correct since gic_ack_irq is currently doing a
maskack, when it should be just an ack. However, since
GENERIC_HARDIRQS_NO__DO_IRQ is always true on ARM, I don't see a need to
add the ifndef.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: cfq-iosched: don't allow aliased requests to starve others
Next: [PATCH] CEPH: Correct obvious typo of Kconfig variable "CRYPTO_AES"