[HACKERS] ECPG pointer vs array
in [PgSql]
|
Prev: [HACKERS] Performance Enhancement/Fix for Array Utility Functions
Next: Performance Enhancement/Fix for Array Utility Functions
From: Boszormenyi Zoltan on 31 Mar 2010 04:37 Hi, It would be good if libecpg to support e.g. "char **strings" instead of "char *strings[]" for preallocated strings and the array of those. IIRC, the first version overwrote my stack in a test programme, as these two are treated the same but they are not. Also, as "numeric" is supposed to be allocated using PGTYPESnumeric_new(), we would need to support array of pointers to numeric, as well as the current static array of numerics. There's no way PGTYPESnumeric_free() works on a static array, e.g. glibc will abort the app with a debug output of free() on an invalid pointer. Freeing the "digit" pointer manually is ugly, numeric has accessor functions, after all. Not doing anything leads to a memory leak. Somehow digitbuf_free() should be make visible outside for such static numeric variables. These and other types came up regarding problems with "FETCH N" in ECPG. All boils down to the same problem: "sometype *ptr" is not equivalent to "sometype ptr[]" if you use &ptr, which is used by ECPG in most cases. Best regards, Zoltán Böszörményi -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zoltán Böszörményi Cybertec Schönig & Schönig GmbH http://www.postgresql.at/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |