Prev: fs, binfmt_aout: Fix pointer warnings
Next: HID: N-trig MTM Driver fix And cleanup patch 5
From: Rafi Rubin on 8 Mar 2010 20:30
> static const struct hid_device_id ntrig_devices[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG, USB_DEVICE_ID_NTRIG_TOUCH_SCREEN),
> - .driver_data = NTRIG_DUPLICATE_USAGES },
> + .driver_data = NTRIG_USB_DEVICE_ID },

The vendor and device id are in the first field "HID_USB_DEVICE", driver
data is for flags, not id. Its merely a coincidence that they are the
same in this case.

The duplicate usages tells hid to let you have more than one "x" and "y"
axis. Otherwise each finger gets a new set (the second finger gets "z"
and "rx" and so on).

> static int __init ntrig_init(void)
> {
> + info("N-trig Driver Version 1.6\n");

Perhaps you mean:
MODULE_VERSION("1.06");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Kosina on 9 Mar 2010 05:20
On Mon, 8 Mar 2010, Rafi Rubin wrote:

> > static int __init ntrig_init(void)
> > {
> > + info("N-trig Driver Version 1.6\n");
>
> Perhaps you mean:
> MODULE_VERSION("1.06");

I'd rather remove all the MODULE_VERSION stuff altogether. git is much
better tracking revisions, once the driver gets merged.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: fs, binfmt_aout: Fix pointer warnings
Next: HID: N-trig MTM Driver fix And cleanup patch 5