Prev: Noticed Issue in kmemleak test module if inserted twice
Next: scsi:hosts.c Fix warning: variable 'rval' set but not used
From: huang ying on 16 Jun 2010 07:00
On Tue, Jun 15, 2010 at 7:22 PM, Avi Kivity <avi(a)redhat.com> wrote:
> btw, is_hwpoison_address() is racy.  While it looks up the address, some
> other task can unmap the page tables under us.
>
> Andi/Huang?
>
> One way of fixing it is get_user_pages_ptes_fast(), which also returns the
> pte, also atomically.  I want it for other reasons as well (respond to a
> read fault by gupping the page for read, but allowing write access if the
> pte indicates it is writeable).

Yes. is_hwpoison_address() is racy. But I think it is not absolutely
necessary to call is_hwpoison_address() in hva_to_pfn_atomic(), is it?

For is_hwpoison_address() in hva_to_pfn(), we can protect it with mmap_sem.

Best Regards,
Huang Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Noticed Issue in kmemleak test module if inserted twice
Next: scsi:hosts.c Fix warning: variable 'rval' set but not used