Prev: linux-next: build warning after merge of the tip tree
Next: drivers/net/e100.c: Use pr_<level> and netif_<level>
From: Xiao Guangrong on 17 Mar 2010 00:30


Takuya Yoshikawa wrote:
> Xiao Guangrong wrote:
>> Using bitmap_empty() to see whether memslot->dirty_bitmap is empty
>>
>
> You can do this for arch specific get_dirty_log() too.

OK, i'll do it in the next version

>
>> Signed-off-by: Xiao Guangrong <xiaoguangrong(a)cn.fujitsu.com>
>> ---
>> virt/kvm/kvm_main.c | 6 ++----
>> 1 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
>> index bcd08b8..497ae14 100644
>> --- a/virt/kvm/kvm_main.c
>> +++ b/virt/kvm/kvm_main.c
>> @@ -767,8 +767,7 @@ int kvm_get_dirty_log(struct kvm *kvm,
>> struct kvm_dirty_log *log, int *is_dirty)
>> {
>> struct kvm_memory_slot *memslot;
>> - int r, i;
>> - int n;
>> + int r, n;
>> unsigned long any = 0;
>
> any is no longer need to be unsigned long, if you do this?

Yeah, right, thanks for you point out.

Xiao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Takuya Yoshikawa on 17 Mar 2010 00:30
Xiao Guangrong wrote:
> Using bitmap_empty() to see whether memslot->dirty_bitmap is empty
>

You can do this for arch specific get_dirty_log() too.

> Signed-off-by: Xiao Guangrong <xiaoguangrong(a)cn.fujitsu.com>
> ---
> virt/kvm/kvm_main.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index bcd08b8..497ae14 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -767,8 +767,7 @@ int kvm_get_dirty_log(struct kvm *kvm,
> struct kvm_dirty_log *log, int *is_dirty)
> {
> struct kvm_memory_slot *memslot;
> - int r, i;
> - int n;
> + int r, n;
> unsigned long any = 0;

any is no longer need to be unsigned long, if you do this?

>
> r = -EINVAL;
> @@ -782,8 +781,7 @@ int kvm_get_dirty_log(struct kvm *kvm,
>
> n = ALIGN(memslot->npages, BITS_PER_LONG) / 8;
>
> - for (i = 0; !any && i < n/sizeof(long); ++i)
> - any = memslot->dirty_bitmap[i];
> + any = !bitmap_empty(memslot->dirty_bitmap, memslot->npages);
>
> r = -EFAULT;
> if (copy_to_user(log->dirty_bitmap, memslot->dirty_bitmap, n))

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: linux-next: build warning after merge of the tip tree
Next: drivers/net/e100.c: Use pr_<level> and netif_<level>