Prev: [Q] Perf-events callchain support on MIPS
Next: Pixelview autitek syntek driver query
From: Samuel Thibault on 5 Jun 2010 19:50
Jiri Slaby, le Sat 05 Jun 2010 23:12:22 +0200, a �crit :
> Fix this by changing the spinlock to mutex as it is used only in
> input_handler->connect and ->disconnect and it is safe to sleep
> there.

Right. in a previous patch it was also used in interrupt context, but
now it should be safe indeed.

Andrew, please fold it into the leds-input patch.

> Signed-off-by: Jiri Slaby <jslaby(a)suse.cz>
> Cc: Richard Purdie <rpurdie(a)rpsys.net>
Acked-by: Samuel Thibault <samuel.thibault(a)ens-lyon.org>

BTW, please also Cc authors of files when reporting bugs... :)

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on 16 Jun 2010 16:50
On Sun, 6 Jun 2010 01:45:06 +0200
Samuel Thibault <samuel.thibault(a)ens-lyon.org> wrote:

> Jiri Slaby, le Sat 05 Jun 2010 23:12:22 +0200, a __crit :
> > Fix this by changing the spinlock to mutex as it is used only in
> > input_handler->connect and ->disconnect and it is safe to sleep
> > there.
>
> Right. in a previous patch it was also used in interrupt context, but
> now it should be safe indeed.
>
> Andrew, please fold it into the leds-input patch.

hm, I did, nine days ago;

btw, leds-route-kbd-leds-through-the-generic-leds-layer.patch is still
in the "stuck" state coz Alessandro said he'd test it ;)

I think I'll start pestering Richard with it anyway.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [Q] Perf-events callchain support on MIPS
Next: Pixelview autitek syntek driver query