LLVM / clang
in [PgSql]
|
From: Gibheer on 30 Jun 2010 14:10 On Fri, 25 Jun 2010 15:49:40 -0400, Peter Eisentraut <peter_e(a)gmx.net> wrote: > > For the record, here is a patch that would address these issues. > > At the moment, I'm waiting to get my hands on the new version 2.7 of > clang to see if some of these issues have gone away. > > Considering that clang already helped us find one bug in the code, I > think it's worth trying to make this work. I tried your patch, but it is only working, when I set CLANG="yes". As I'm not really an expert in makefiles, my first thought was, that it should work, when I set CC="clang" or is it not possible to detect, which compiler is used? -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Peter Eisentraut on 30 Jun 2010 18:29 On ons, 2010-06-30 at 20:10 +0200, Gibheer wrote: > On Fri, 25 Jun 2010 15:49:40 -0400, Peter Eisentraut <peter_e(a)gmx.net> > wrote: > > > > For the record, here is a patch that would address these issues. > > > > At the moment, I'm waiting to get my hands on the new version 2.7 of > > clang to see if some of these issues have gone away. > > > > Considering that clang already helped us find one bug in the code, I > > think it's worth trying to make this work. > > I tried your patch, but it is only working, when I set CLANG="yes". As > I'm not really an expert in makefiles, my first thought was, that it > should work, when I set CC="clang" or is it not possible to detect, > which compiler is used? I suspect you didn't run autoreconf. -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Peter Eisentraut on 8 Jul 2010 16:17 On fre, 2010-06-25 at 15:49 -0400, Peter Eisentraut wrote: > For the record, here is a patch that would address these issues. > > At the moment, I'm waiting to get my hands on the new version 2.7 of > clang to see if some of these issues have gone away. > > Considering that clang already helped us find one bug in the code, I > think it's worth trying to make this work. So, clang 2.7 didn't fix it. Do we want to proceed with my patch or leave clang unsupported? -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 8 Jul 2010 16:39 Peter Eisentraut <peter_e(a)gmx.net> writes: > So, clang 2.7 didn't fix it. Do we want to proceed with my patch or > leave clang unsupported? Given that the patch breaks plperl, I'd vote no ... but in any case right now is not the time to be applying it. Maybe it would be useful to put it in HEAD after we branch 9.0. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Peter Eisentraut on 10 Jul 2010 18:22
On fre, 2010-06-11 at 07:00 +0300, Peter Eisentraut wrote: > The second problem is that the prototype check for accept() fails. > This > is because glibc defines the second argument to be a "transparent > union", apparently to make it look like a lot of things at once. > clang > apparently doesn't understand that. One could address this by > checking > for the typedef that glibc uses explicitly in the configure check, but > that would appear to defeat the point of the *transparent* union. A > workaround is to remove -D_GNU_SOURCE from src/template/linux. For the record, there is already a bug report about this: http://llvm.org/bugs/show_bug.cgi?id=5365 -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |