From: Robert Haas on
2010/2/4 KaiGai Kohei <kaigai(a)ak.jp.nec.com>:
> (2010/02/04 0:20), Robert Haas wrote:
>> 2010/2/1 KaiGai Kohei<kaigai(a)ak.jp.nec.com>:
>>> I again wonder whether we are on the right direction.
>>
>> I believe the proposed approach is to dump blob metadata if and only
>> if you are also dumping blob contents, and to do all of this for data
>> dumps but not schema dumps.  That seems about right to me.
>
> In other words:
>
>  <default>     -> blob contents and metadata (owner, acl, comments) shall
>                  be dumped
>  --data-only   -> only blob contents shall be dumped
>  --schema-only -> neither blob contents and metadata are dumped.
>
> Can I understand correctly?

No, that's not what I said. Please reread. I don't think you should
ever dump blob contents without the metadata, or the other way around.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Alvaro Herrera on
Robert Haas escribi�:
> 2010/2/4 KaiGai Kohei <kaigai(a)ak.jp.nec.com>:
> > (2010/02/04 0:20), Robert Haas wrote:
> >> 2010/2/1 KaiGai Kohei<kaigai(a)ak.jp.nec.com>:
> >>> I again wonder whether we are on the right direction.
> >>
> >> I believe the proposed approach is to dump blob metadata if and only
> >> if you are also dumping blob contents, and to do all of this for data
> >> dumps but not schema dumps. �That seems about right to me.
> >
> > In other words:
> >
> > �<default> � � -> blob contents and metadata (owner, acl, comments) shall
> > � � � � � � � � �be dumped
> > �--data-only � -> only blob contents shall be dumped
> > �--schema-only -> neither blob contents and metadata are dumped.
> >
> > Can I understand correctly?
>
> No, that's not what I said. Please reread. I don't think you should
> ever dump blob contents without the metadata, or the other way around.

So:
default: both contents and metadata
--data-only: same
--schema-only: neither

Seems reasonable.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: KaiGai Kohei on
(2010/02/05 3:27), Alvaro Herrera wrote:
> Robert Haas escribi�:
>> 2010/2/4 KaiGai Kohei<kaigai(a)ak.jp.nec.com>:
>>> (2010/02/04 0:20), Robert Haas wrote:
>>>> 2010/2/1 KaiGai Kohei<kaigai(a)ak.jp.nec.com>:
>>>>> I again wonder whether we are on the right direction.
>>>>
>>>> I believe the proposed approach is to dump blob metadata if and only
>>>> if you are also dumping blob contents, and to do all of this for data
>>>> dumps but not schema dumps. That seems about right to me.
>>>
>>> In other words:
>>>
>>> <default> -> blob contents and metadata (owner, acl, comments) shall
>>> be dumped
>>> --data-only -> only blob contents shall be dumped
>>> --schema-only -> neither blob contents and metadata are dumped.
>>>
>>> Can I understand correctly?
>>
>> No, that's not what I said. Please reread. I don't think you should
>> ever dump blob contents without the metadata, or the other way around.
>
> So:
> default: both contents and metadata
> --data-only: same
> --schema-only: neither
>
> Seems reasonable.

OK... I'll try to update the patch, anyway.

However, it means only large object performs an exceptional object class
that dumps its owner, acl and comment even if --data-only is given.
Is it really what you suggested, isn't it?

Thanks,
--
KaiGai Kohei <kaigai(a)kaigai.gr.jp>

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Takahiro Itagaki on

KaiGai Kohei <kaigai(a)kaigai.gr.jp> wrote:

> > default: both contents and metadata
> > --data-only: same
> > --schema-only: neither
>
> However, it means only large object performs an exceptional object class
> that dumps its owner, acl and comment even if --data-only is given.
> Is it really what you suggested, isn't it?

I wonder we still need to have both "BLOB ITEM" and "BLOB DATA"
even if we will take the all-or-nothing behavior. Can we handle
BLOB's owner, acl, comment and data with one entry kind?

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center



--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: KaiGai Kohei on
(2010/02/05 13:53), Takahiro Itagaki wrote:
>
> KaiGai Kohei<kaigai(a)kaigai.gr.jp> wrote:
>
>>> default: both contents and metadata
>>> --data-only: same
>>> --schema-only: neither
>>
>> However, it means only large object performs an exceptional object class
>> that dumps its owner, acl and comment even if --data-only is given.
>> Is it really what you suggested, isn't it?
>
> I wonder we still need to have both "BLOB ITEM" and "BLOB DATA"
> even if we will take the all-or-nothing behavior. Can we handle
> BLOB's owner, acl, comment and data with one entry kind?

Is it possible to fetch a certain blob from tar/custom archive
when pg_restore found a toc entry of the blob?

Currently, when pg_restore found a "BLOB DATA" or "BLOBS" entry,
it opens the archive and restores all the blob objects sequentially.
It seems to me we also have to rework the custom format........

Thanks,
--
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai(a)ak.jp.nec.com>

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers